-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[snmp] removing unneeded go-variant #3164
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3164 +/- ##
=========================================
+ Coverage 54.38% 54.6% +0.21%
=========================================
Files 541 542 +1
Lines 38762 38627 -135
=========================================
+ Hits 21081 21091 +10
+ Misses 16425 16289 -136
+ Partials 1256 1247 -9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from a few relevant references in two docs, I think you 🔥 it all.
https://github.com/DataDog/datadog-agent/blob/master/docs/dev/agent_build.md
https://github.com/DataDog/datadog-agent/blob/master/docs/dev/agent_dev_env.md
Feel free to merge once addressed.
What does this PR do?
Removes the SNMP go check and all it's moving parts (ie. net-snmp).
Motivation
Python snmp check now behaves well enough in an A6 multi-runner universe, and is way more maintainable.
Additional Notes
Let's check all is well in the resulting omnibus build, including some python SNMP testing.