Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snmp] removing unneeded go-variant #3164

Merged
merged 6 commits into from
Mar 26, 2019
Merged

[snmp] removing unneeded go-variant #3164

merged 6 commits into from
Mar 26, 2019

Conversation

truthbk
Copy link
Member

@truthbk truthbk commented Mar 18, 2019

What does this PR do?

Removes the SNMP go check and all it's moving parts (ie. net-snmp).

Motivation

Python snmp check now behaves well enough in an A6 multi-runner universe, and is way more maintainable.

Additional Notes

Let's check all is well in the resulting omnibus build, including some python SNMP testing.

@truthbk truthbk requested a review from a team as a code owner March 18, 2019 18:08
@truthbk truthbk added this to the 6.11.0 milestone Mar 18, 2019
@truthbk truthbk added the [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead.. label Mar 18, 2019
@truthbk truthbk requested a review from a team as a code owner March 18, 2019 18:33
@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #3164 into master will increase coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #3164      +/-   ##
=========================================
+ Coverage   54.38%   54.6%   +0.21%     
=========================================
  Files         541     542       +1     
  Lines       38762   38627     -135     
=========================================
+ Hits        21081   21091      +10     
+ Misses      16425   16289     -136     
+ Partials     1256    1247       -9
Flag Coverage Δ
#linux 57.66% <ø> (+0.3%) ⬆️
#windows 56.21% <ø> (+0.09%) ⬆️
Impacted Files Coverage Δ
cmd/agent/app/jmx.go 16.12% <0%> (-0.54%) ⬇️
cmd/agent/app/control_service_windows.go 2.58% <0%> (-0.5%) ⬇️
cmd/agent/app/integrations.go 21.33% <0%> (-0.26%) ⬇️
cmd/agent/app/check.go 5.12% <0%> (-0.22%) ⬇️
cmd/agent/gui/agent.go 0% <0%> (ø) ⬆️
pkg/secrets/info.go 0% <0%> (ø) ⬆️
cmd/agent/app/integrations_windows.go 0% <0%> (ø) ⬆️
pkg/forwarder/transaction.go 82.9% <0%> (ø) ⬆️
cmd/agent/app/dependent_services_windows.go 0% <0%> (ø) ⬆️
pkg/secrets/info_windows.go 65.51% <0%> (ø)
... and 4 more

arbll
arbll previously approved these changes Mar 20, 2019
Copy link
Member

@arbll arbll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a few relevant references in two docs, I think you 🔥 it all.

https://github.com/DataDog/datadog-agent/blob/master/docs/dev/agent_build.md
https://github.com/DataDog/datadog-agent/blob/master/docs/dev/agent_dev_env.md

Feel free to merge once addressed.

@truthbk truthbk requested a review from a team as a code owner March 26, 2019 09:33
@truthbk truthbk merged commit fe562e3 into master Mar 26, 2019
@truthbk truthbk deleted the jaime/snmpburn branch March 26, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants