Skip to content
This repository was archived by the owner on Oct 21, 2024. It is now read-only.

Commit c515393

Browse files
committed
[ARROW-6738][Java] Rule out the change for union type comparison
1 parent bab7402 commit c515393

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

java/vector/src/main/java/org/apache/arrow/vector/compare/RangeEqualsVisitor.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,9 @@ protected boolean compareUnionVectors(Range range) {
217217
return false;
218218
}
219219
}
220-
RangeEqualsVisitor visitor = createInnerVisitor(leftSubVector, rightSubVector, true);
220+
TypeEqualsVisitor typeVisitor = new TypeEqualsVisitor(rightSubVector);
221+
RangeEqualsVisitor visitor =
222+
createInnerVisitor(leftSubVector, rightSubVector, (left, right) -> typeVisitor.equals(left));
221223
if (!visitor.rangeEquals(subRange)) {
222224
return false;
223225
}

java/vector/src/test/java/org/apache/arrow/vector/compare/TestRangeEqualsVisitor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -309,8 +309,8 @@ public void testUnionVectorSubRangeEquals() {
309309
vector1.setSafe(2, intHolder);
310310
vector1.setValueCount(3);
311311

312-
vector2.setType(0, Types.MinorType.SMALLINT);
313-
vector2.setSafe(0, intHolder);
312+
vector2.setType(0, Types.MinorType.UINT4);
313+
vector2.setSafe(0, uInt4Holder);
314314

315315
vector2.setType(1, Types.MinorType.INT);
316316
vector2.setSafe(1, intHolder);

0 commit comments

Comments
 (0)