Implementing review feedback.

Author: rok

cpp/src/arrow/sparse_tensor.cc

@@ -1006,8 +1006,8 @@ Result<std::shared_ptr<SparseCSFIndex>> SparseCSFIndex::Make(
     const std::shared_ptr<DataType>& indptr_type,
     const std::shared_ptr<DataType>& indices_type,
     const std::vector<int64_t>& indices_shapes, const std::vector<int64_t>& axis_order,
-    std::vector<std::shared_ptr<Buffer>> indptr_data,
-    std::vector<std::shared_ptr<Buffer>> indices_data) {
+    const std::vector<std::shared_ptr<Buffer>>& indptr_data,
+    const std::vector<std::shared_ptr<Buffer>>& indices_data) {
   int64_t ndim = axis_order.size();
   std::vector<std::shared_ptr<Tensor>> indptr(ndim - 1);
   std::vector<std::shared_ptr<Tensor>> indices(ndim);
@@ -1027,8 +1027,8 @@ Result<std::shared_ptr<SparseCSFIndex>> SparseCSFIndex::Make(
 }
 
 // Constructor with two index vectors
-SparseCSFIndex::SparseCSFIndex(std::vector<std::shared_ptr<Tensor>>& indptr,
-                               std::vector<std::shared_ptr<Tensor>>& indices,
+SparseCSFIndex::SparseCSFIndex(const std::vector<std::shared_ptr<Tensor>>& indptr,
+                               const std::vector<std::shared_ptr<Tensor>>& indices,
                                const std::vector<int64_t>& axis_order)
     : SparseIndexBase(indices.back()->size()),
       indptr_(indptr),

cpp/src/arrow/sparse_tensor.h

@@ -354,22 +354,22 @@ class ARROW_EXPORT SparseCSFIndex : public internal::SparseIndexBase<SparseCSFIn
       const std::shared_ptr<DataType>& indptr_type,
       const std::shared_ptr<DataType>& indices_type,
       const std::vector<int64_t>& indices_shapes, const std::vector<int64_t>& axis_order,
-      std::vector<std::shared_ptr<Buffer>> indptr_data,
-      std::vector<std::shared_ptr<Buffer>> indices_data);
+      const std::vector<std::shared_ptr<Buffer>>& indptr_data,
+      const std::vector<std::shared_ptr<Buffer>>& indices_data);
 
   /// \brief Make SparseCSFIndex from raw properties
   static Result<std::shared_ptr<SparseCSFIndex>> Make(
       const std::shared_ptr<DataType>& indices_type,
       const std::vector<int64_t>& indices_shapes, const std::vector<int64_t>& axis_order,
-      std::vector<std::shared_ptr<Buffer>> indptr_data,
-      std::vector<std::shared_ptr<Buffer>> indices_data) {
+      const std::vector<std::shared_ptr<Buffer>>& indptr_data,
+      const std::vector<std::shared_ptr<Buffer>>& indices_data) {
     return Make(indices_type, indices_type, indices_shapes, axis_order, indptr_data,
                 indices_data);
   }
 
   /// \brief Construct SparseCSFIndex from two index vectors
-  explicit SparseCSFIndex(std::vector<std::shared_ptr<Tensor>>& indptr,
-                          std::vector<std::shared_ptr<Tensor>>& indices,
+  explicit SparseCSFIndex(const std::vector<std::shared_ptr<Tensor>>& indptr,
+                          const std::vector<std::shared_ptr<Tensor>>& indices,
                           const std::vector<int64_t>& axis_order);
 
   /// \brief Return a 1D vector of indptr tensors

cpp/src/arrow/sparse_tensor_test.cc

@@ -950,8 +950,9 @@ class TestSparseCSFTensorForIndexValueType
  protected:
   std::shared_ptr<SparseCSFIndex> MakeSparseCSFIndex(
       const std::vector<int64_t>& axis_order,
-      std::vector<std::vector<typename IndexValueType::c_type>>& indptr_values,
-      std::vector<std::vector<typename IndexValueType::c_type>>& indices_values) const {
+      const std::vector<std::vector<typename IndexValueType::c_type>>& indptr_values,
+      const std::vector<std::vector<typename IndexValueType::c_type>>& indices_values)
+      const {
     int64_t ndim = axis_order.size();
     std::vector<std::shared_ptr<Tensor>> indptr(ndim - 1);
     std::vector<std::shared_ptr<Tensor>> indices(ndim);