revert changes in copyFrom

Author: tianchen92

java/performance/src/test/java/org/apache/arrow/vector/util/TransferPairBenchmarks.java

@@ -408,8 +408,6 @@ public TransferPair makeTransferPair(ValueVector target) {
   @Override
   public void copyFrom(int inIndex, int outIndex, ValueVector from) {
     Preconditions.checkArgument(this.getMinorType() == from.getMinorType());
-    Preconditions.checkArgument(inIndex >= 0 && inIndex < from.getValueCount(),
-        "Invalid inIndex: %s", inIndex);
     UnionVector fromCast = (UnionVector) from;
     fromCast.getReader().setPosition(inIndex);
     getWriter().setPosition(outIndex);

java/vector/src/main/codegen/templates/UnionVector.java

@@ -833,8 +833,6 @@ protected void handleSafe(int index) {
   @Override
   public void copyFrom(int fromIndex, int thisIndex, ValueVector from) {
     Preconditions.checkArgument(this.getMinorType() == from.getMinorType());
-    Preconditions.checkArgument(fromIndex >= 0 && fromIndex < from.getValueCount(),
-        "Invalid fromIndex: %s", fromIndex);
     if (from.isNull(fromIndex)) {
       BitVectorHelper.unsetBit(this.getValidityBuffer(), thisIndex);
     } else {
@@ -856,8 +854,6 @@ public void copyFrom(int fromIndex, int thisIndex, ValueVector from) {
   @Override
   public void copyFromSafe(int fromIndex, int thisIndex, ValueVector from) {
     Preconditions.checkArgument(this.getMinorType() == from.getMinorType());
-    Preconditions.checkArgument(fromIndex >= 0 && fromIndex < from.getValueCount(),
-        "Invalid fromIndex: %s", fromIndex);
     handleSafe(thisIndex);
     copyFrom(fromIndex, thisIndex, from);
   }

java/vector/src/main/java/org/apache/arrow/vector/BaseFixedWidthVector.java

@@ -1339,8 +1339,6 @@ public void copyFrom(int fromIndex, int thisIndex, ValueVector from) {
   @Override
   public void copyFromSafe(int fromIndex, int thisIndex, ValueVector from) {
     Preconditions.checkArgument(this.getMinorType() == from.getMinorType());
-    Preconditions.checkArgument(fromIndex >= 0 && fromIndex < from.getValueCount(),
-        "Invalid fromIndex: %s", fromIndex);
     if (from.isNull(fromIndex)) {
       handleSafe(thisIndex, 0);
       fillHoles(thisIndex);

java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthVector.java

@@ -364,8 +364,6 @@ public void copyFromSafe(int inIndex, int outIndex, ValueVector from) {
   @Override
   public void copyFrom(int inIndex, int outIndex, ValueVector from) {
     Preconditions.checkArgument(this.getMinorType() == from.getMinorType());
-    Preconditions.checkArgument(inIndex >= 0 && inIndex < from.getValueCount(),
-        "Invalid inIndex: %s", inIndex);
     FieldReader in = from.getReader();
     in.setPosition(inIndex);
     FieldWriter out = getWriter();

java/vector/src/main/java/org/apache/arrow/vector/complex/ListVector.java

@@ -99,8 +99,6 @@ public FieldReader getReader() {
   @Override
   public void copyFrom(int fromIndex, int thisIndex, ValueVector from) {
     Preconditions.checkArgument(this.getMinorType() == from.getMinorType());
-    Preconditions.checkArgument(fromIndex >= 0 && fromIndex < from.getValueCount(),
-        "Invalid fromIndex: %s", fromIndex);
     if (ephPair == null || ephPair.from != from) {
       ephPair = (StructTransferPair) from.makeTransferPair(this);
     }

java/vector/src/main/java/org/apache/arrow/vector/complex/NonNullableStructVector.java

@@ -29,6 +29,7 @@
 import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;
+import org.junit.jupiter.api.Assertions;
 
 public class TestSplitAndTransfer {
   private BufferAllocator allocator;
@@ -172,22 +173,6 @@ public void testCopyValueSafe() {
     }
   }
 
-  @Test(expected = IllegalArgumentException.class)
-  public void testInvalidCopyValueSafe() {
-    try (final VarCharVector varCharVector = new VarCharVector("myvector", allocator);
-        final VarCharVector newVarCharVector = new VarCharVector("newvector", allocator)) {
-      varCharVector.allocateNew(10000, 1000);
-
-      final int valueCount = 500;
-      populateVarcharVector(varCharVector, valueCount, null);
-
-      final TransferPair tp = varCharVector.makeTransferPair(newVarCharVector);
-
-      // fromIndex is invalid.
-      tp.copyValueSafe(valueCount, 0);
-    }
-  }
-
   @Test
   public void testSplitAndTransferNon() {
     try (final VarCharVector varCharVector = new VarCharVector("myvector", allocator)) {
@@ -224,7 +209,7 @@ public void testSplitAndTransferAll() {
     }
   }
 
-  @Test(expected = IllegalArgumentException.class)
+  @Test
   public void testInvalidStartIndex() {
     try (final VarCharVector varCharVector = new VarCharVector("myvector", allocator);
         final VarCharVector newVarCharVector = new VarCharVector("newvector", allocator)) {
@@ -235,13 +220,17 @@ public void testInvalidStartIndex() {
 
       final TransferPair tp = varCharVector.makeTransferPair(newVarCharVector);
 
-      tp.splitAndTransfer(valueCount, 10);
+      IllegalArgumentException e = Assertions.assertThrows(
+          IllegalArgumentException.class,
+          () -> tp.splitAndTransfer(valueCount, 10));
+
+      assertEquals("Invalid startIndex: 500", e.getMessage());
 
       newVarCharVector.clear();
     }
   }
 
-  @Test(expected = IllegalArgumentException.class)
+  @Test
   public void testInvalidLength() {
     try (final VarCharVector varCharVector = new VarCharVector("myvector", allocator);
         final VarCharVector newVarCharVector = new VarCharVector("newvector", allocator)) {
@@ -252,7 +241,11 @@ public void testInvalidLength() {
 
       final TransferPair tp = varCharVector.makeTransferPair(newVarCharVector);
 
-      tp.splitAndTransfer(0, valueCount * 2);
+      IllegalArgumentException e = Assertions.assertThrows(
+          IllegalArgumentException.class,
+          () -> tp.splitAndTransfer(0, valueCount * 2));
+
+      assertEquals("Invalid length: 1000", e.getMessage());
 
       newVarCharVector.clear();
     }