[protobuf] remove logs java protobuf and upgrade logs go compiler to non-legacy #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…non-legacy This generated java is no longer used, instead the logs java backend copies the protobuf file and regenerates using their own generator. There are no differences between the legacy and modern proto compiler for Go, so we can upgrade to the latest protobuf compiler. This is thefinal step before we can remove the legacy protobuf compiler.
leeavital
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generated java is no longer used, instead the logs java backend copies the protobuf file and regenerates using their own generator.
There are no differences between the legacy and modern proto compiler for Go, so we can upgrade to the latest protobuf compiler.
This is the final step before we can remove the legacy protobuf compiler.
What does this PR do?
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Reviewers: please see the review guidelines.