Skip to content

[CORE-580] Improved Data Table Performance Setting (Quicksilver Migration) #5358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from

Conversation

kevinmarete
Copy link
Contributor

@kevinmarete kevinmarete commented Jul 9, 2025

Jira Ticket: https://broadworkbench.atlassian.net/browse/CORE-580

What

  • Adds a workspace setting in the UI to enable improved data table performance.
  • Only visible to Core Services admins and controlled by a private feature flag.
  • The setting is tracked in Mixpanel and becomes read-only once enabled.

Why

  • Makes the migration option visible and easy to use.
  • Allows controlled rollout and tracking instead of relying on dev tools or the API.

Testing strategy

  • Unit Testing:
    • Added unit tests for the new setting
  • Manual Testing
    • Verify that only Core Services admins can see and enable the setting.
    • Check that the setting appears with the correct description and becomes read-only after enabling.
    • Ensure Mixpanel tracks when the setting is viewed and enabled.
    • Confirm no way to disable the setting after enabling, and no migration reversal option.
    • Validate support/contact info is correct if present.

Screens

Feature Flag
Feature Flag

Setting Enabled
Screenshot 2025-07-10 at 12 02 45 AM

Setting Disabled
Screenshot 2025-07-10 at 12 02 12 AM

@kevinmarete kevinmarete self-assigned this Jul 9, 2025
@kevinmarete kevinmarete marked this pull request as ready for review July 9, 2025 04:15
@kevinmarete kevinmarete requested a review from a team as a code owner July 9, 2025 04:15
@kevinmarete kevinmarete marked this pull request as draft July 10, 2025 04:06
@kevinmarete kevinmarete requested review from davidangb and admull July 11, 2025 06:03
@kevinmarete kevinmarete marked this pull request as ready for review July 11, 2025 13:31
Copy link
Contributor

@davidangb davidangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes ALL workspace settings asynchronous ... is that desired? If so, great! If not, I think that the backend Rawls API should handle the Quicksilver migration asynchronously and return quickly, so this UI change may not be needed at all.

@kevinmarete kevinmarete requested review from davidangb and admull and removed request for admull July 11, 2025 19:45
Copy link
Contributor

@davidangb davidangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, agreeing with you that we should not merge this until the Rawls side of it is live in prod.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants