Skip to content

Change Analysis Tools to External Resources for tertiary portals hand-off. Resolves #974. #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2019
Merged

Change Analysis Tools to External Resources for tertiary portals hand-off. Resolves #974. #983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spa/src/app/files/hca-project/hca-project.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,12 +138,12 @@ <h4 class="fontsize-m semi-bold">Project Downloads</h4>
</div>
</div>
<div class="project-integrations">
<h4 class="fontsize-m semi-bold">Analysis Tools</h4>
<h4 class="fontsize-m semi-bold">External Resources</h4>
<ng-container [ngSwitch]="state.integratedWithTertiaryPortals">
<ng-container *ngSwitchCase="true">
<div class="stretch">
<p class="fontsize-xs">This project's data can be viewed live in the following
analysis tools:</p>
external resources:</p>
</div>
<project-integrations [integrations]="state.integrations"></project-integrations>
</ng-container>
Expand Down
10 changes: 5 additions & 5 deletions spa/src/app/files/hca-project/hca-project.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ describe("HCAProjectComponent", () => {
const COMPONENT_NAME_COPY_TO_CLIPBOARD = "copy-to-clipboard";

// Heading labels
const HEADING_ANALYSIS_TOOLS = "Analysis Tools";
const HEADING_CITATION = "Citation";
const HEADING_EXTERNAL_RESOURCES = "External Resources";

// Project matrix urls
const PROJECT_DETAIL_PROJECT_MATRIX_URLS = new ProjectMatrixUrls("2cd14cf5-f8e0-4c97-91a2-9e8957f41ea8", "https://dev.data.humancellatlas.org/project-assets/project-matrices/537f5501-a964-4ade-91c8-7bd4a23b049d.csv.zip", "https://dev.data.humancellatlas.org/project-assets/project-matrices/537f5501-a964-4ade-91c8-7bd4a23b049d.loom", "https://dev.data.humancellatlas.org/project-assets/project-matrices/537f5501-a964-4ade-91c8-7bd4a23b049d.mtx.zip");
Expand Down Expand Up @@ -526,9 +526,9 @@ describe("HCAProjectComponent", () => {
});

/**
* Confirm "Analysis Tools" is displayed.
* Confirm "External Resources" is displayed.
*/
it(`should display "Analysis Tools"`, () => {
it(`should display "External Resources"`, () => {

testStore.pipe
.and.returnValues(
Expand All @@ -540,8 +540,8 @@ describe("HCAProjectComponent", () => {

fixture.detectChanges();

// Confirm "Analysis Tools" is displayed
expect(isHeadingDisplayed(HEADING_ANALYSIS_TOOLS)).toEqual(true);
// Confirm "External Resources" is displayed
expect(isHeadingDisplayed(HEADING_EXTERNAL_RESOURCES)).toEqual(true);
});

/**
Expand Down