Skip to content

Conversation

@frano-m
Copy link
Contributor

@frano-m frano-m commented Jun 17, 2025

Ticket

Closes #4510.

Reviewers

@NoopDog.

This pull request introduces changes to the e2e/anvil test suite and updates a package dependency. The most notable changes include adding support for a "Request Link" button in the dataset tests and updating the @databiosphere/findable-ui package version.

Changes to dataset tests:

  • e2e/anvil/anvil-dataset.spec.ts: Added BUTTON_TEXT_REQUEST_LINK to the imports and updated the test logic to verify the presence of a single "Request Link" button instead of two buttons for file manifest actions. [1] [2]
  • e2e/anvil/common/constants.tsx: Added a new constant BUTTON_TEXT_REQUEST_LINK to represent the text for the "Request Link" button.

Dependency update:

  • package.json: Updated the @databiosphere/findable-ui dependency from version ^35.1.0 to ^35.2.0.
image

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the @databiosphere/findable-ui package to version 35.2.0 and makes adjustments to the e2e/anvil test suite.

  • Updates the dependency version in package.json
  • Introduces a new constant BUTTON_TEXT_REQUEST_LINK in constants.tsx
  • Updates dataset tests in anvil-dataset.spec.ts to verify a single "Request Link" button instead of two buttons for file manifest actions

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
package.json Updated the @databiosphere/findable-ui dependency version
e2e/anvil/common/constants.tsx Added the new BUTTON_TEXT_REQUEST_LINK constant
e2e/anvil/anvil-dataset.spec.ts Modified the test logic to verify the presence of one "Request Link" button
Comments suppressed due to low confidence (1)

e2e/anvil/anvil-dataset.spec.ts:110

  • The comment still references 'file manifest' while the test now checks for a 'Request Link' button. Please update the comment to accurately reflect the current functionality.
    // Confirm the file manifest page is loaded: check there is one button to request the manifest.

@NoopDog NoopDog merged commit 68519c7 into main Jun 17, 2025
4 checks passed
@frano-m frano-m deleted the fran/4510-findable branch June 17, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[HCA DCP] Upgrade findable-ui package to 35.2.0

3 participants