chore: update findable-ui package to latest version v27.0.0 (#4466) #4467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the dependency version of @databiosphere/findable-ui to v27.0.0 while refactoring various import paths and style constants to align with the latest package structure. It also removes redundant ESLint settings to simplify configuration.
- Upgraded findable-ui and related dependencies
- Updated EXPLORE_MODE import paths for improved type specificity
- Replaced old color constants with centralized PALETTE constants and simplified ESLint configuration
Reviewed Changes
Copilot reviewed 28 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| site-config/anvil/dev/index/datasetsEntityConfig.ts | Updated EXPLORE_MODE import path to use the new "types" subpath |
| site-config/anvil/dev/index/biosamplesEntityConfig.ts | Updated EXPLORE_MODE import path to use the new "types" subpath |
| site-config/anvil/dev/index/activitiesEntityConfig.ts | Updated EXPLORE_MODE import path to use the new "types" subpath |
| site-config/anvil-cmg/dev/index/librariesEntityConfig.ts | Updated EXPLORE_MODE import path to use the new "types" subpath |
| site-config/anvil-cmg/dev/index/filesEntityConfig.ts | Updated EXPLORE_MODE import path to use the new "types" subpath |
| site-config/anvil-cmg/dev/index/donorsEntityConfig.ts | Updated EXPLORE_MODE import path to use the new "types" subpath |
| site-config/anvil-cmg/dev/index/datasetsEntityConfig.ts | Updated EXPLORE_MODE import path to use the new "types" subpath |
| site-config/anvil-cmg/dev/index/biosamplesEntityConfig.ts | Updated EXPLORE_MODE import path to use the new "types" subpath |
| site-config/anvil-cmg/dev/index/activitiesEntityConfig.ts | Updated EXPLORE_MODE import path to use the new "types" subpath |
| site-config/anvil-cmg/dev/config.ts | Commented out the dataDictionary import and usage for cleanup |
| site-config/anvil-catalog/dev/index/workspaceEntityConfig.ts | Updated EXPLORE_MODE import path to use the new "types" subpath |
| site-config/anvil-catalog/dev/index/studiesEntityConfig.ts | Updated EXPLORE_MODE import path to use the new "types" subpath |
| site-config/anvil-catalog/dev/index/consortiaEntityConfig.ts | Updated EXPLORE_MODE import path to use the new "types" subpath |
| pages/[entityListType]/index.tsx | Updated EXPLORE_MODE import path to use the new "types" subpath |
| pages/[entityListType]/[...params].tsx | Updated EXPLORE_MODE import path to use the new "types" subpath |
| app/components/common/Figure/figure.styles.ts | Replaced smokeMain with PALETTE.SMOKE_MAIN for consistency |
| app/components/Detail/components/MDX/components/Table/table.styles.ts | Replaced smokeMain with PALETTE.SMOKE_MAIN for consistency |
| app/components/Detail/components/AnVILCMG/components/RequestAccess/requestAccess.styles.ts | Replaced primaryDark with PALETTE.PRIMARY_DARK for consistency |
Files not reviewed (2)
- .eslintrc.json: Language not supported
- package.json: Language not supported
frano-m
commented
Apr 24, 2025
Contributor
Author
frano-m
left a comment
frano-m
left a comment
There was a problem hiding this comment.
Nice @MillenniumFalconMechanic thank you! 🥇
frano-m
changed the title
NoopDog
approved these changes
Apr 24, 2025
MillenniumFalconMechanic
approved these changes
Apr 24, 2025
Contributor
MillenniumFalconMechanic
left a comment
MillenniumFalconMechanic
left a comment
There was a problem hiding this comment.
LGTM, thanks F!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Closes #4466.
Reviewers
@MillenniumFalconMechanic, @NoopDog.
Changes
findable-uito latest versionv27.0.0.react-hooksfrom.eslintrc.jsonaseslint-config-nextalready includesplugin:react-hooks/recommended.This pull request includes updates to dependencies, code refactoring for consistent imports, and configuration changes. The most notable changes involve upgrading packages, replacing color constants with a centralized palette, and modifying imports for better type specificity.
Dependency Updates:
@databiosphere/findable-uifrom^25.1.0to^27.0.0, along with several related dependencies such asnext,next-mdx-remote, andeslint-config-nextto their latest versions. These updates may include breaking changes that require testing. [1] [2] [3] [4]Code Refactoring:
primaryDarkandsmokeMainwith centralizedPALETTEconstants for better maintainability and consistency across files (requestAccess.styles.ts,table.styles.ts,figure.styles.ts). [1] [2] [3] [4] [5]EXPLORE_MODEto referenceuseExploreMode/typesinstead ofuseExploreModefor improved type specificity and clarity across multiple files. (pages/[entityListType]/[...params].tsxL20-R20, pages/[entityListType]/index.tsxL6-R6, [1] [2] [3] and others)Configuration Changes:
react-hooksfrom the.eslintrc.jsonplugins and rules, as it is no longer used. This simplifies the ESLint configuration. [1] [2]dataDictionaryimport and usage insite-config/anvil-cmg/dev/config.ts, possibly for deprecation or debugging purposes. [1] [2]