feat: added pageviews analytics functions (#4336) #4339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Seems like this was closed erroneously as a result of being accidentally referenced as the ticket for #4335 |
Contributor
Author
|
Whoops! Thanks for reopening @hunterckx |
mrtopsyt
force-pushed
the
jonah/4336-add-page-views-to-analytics-package
branch
from
f593732 to
6c12a65
Compare
mrtopsyt
force-pushed
the
jonah/4336-add-page-views-to-analytics-package
branch
from
0b5c3c3 to
eff8ff7
Compare
hunterckx
requested changes
Jan 22, 2025
| series_current_reindexed = series_current.reindex(combined_index).fillna(0) | ||
| # Adjust the values from the prior series to account for the different number of days in the month | ||
| series_previous_reindexed = (series_previous.reindex(combined_index) * current_length / previous_length) | ||
| change = ((series_previous_reindexed / series_current_reindexed) - 1).replace({np.inf: np.nan}) |
Contributor
There was a problem hiding this comment.
Looks like the division might be backward here if we want change from previous to current?
hunterckx
approved these changes
Jan 23, 2025
MillenniumFalconMechanic
deleted the
jonah/4336-add-page-views-to-analytics-package
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Closes #4336.
Reviewers
@hunterckx.
@NoopDog
Changes
Notes