Finalize the "DCU004.001 Verify SMMSTORE changes" test case

[macpijan]

Test environment version

• Branch: develop
• Commit: 540916c

Dasharo version (if applicable)

N/A

Dasharo variant (if applicable)

N/A

Affected component(s) or functionality (if applicable)

Brief summary

It seems this test has never been finalized: https://github.com/Dasharo/open-source-firmware-validation/blob/dcbfa25002de61b0ab812e6caacb51397cefe875/dasharo-compatibility/dcu.robot#L97C1-L97C35

Additional context

It may be that at the time of writing it, the DCU has not supported SMMSTORE changes yet. But now it does, and we could finalize this test and make sure it works correctly.

[philipandag]

It seems that the test was expected to be run on a device which supports tests in the setup menu. The dcu utility allows to check for the values of variables, so I think it might be better to use it to check them.

After performing all the writes the fw from the chip could be read to a separate file and the variables could be checked in the file.

Although using the tested utility to test itself might lead to problems. I think I will create two implementations of the test. One in the setup menu via serial and one via ssh as a self-test of dcu.

[philipandag]

Another issue here is that not every smmstore variable suggested in the comments is implemented in dcu. I think changing and verifying one variable should be enough to test if writing to the SMMSTORE works.

[philipandag]

Tests added in #543

Logs:
dcu.robot_log_.zip

[krystian-hebel]

Although using the tested utility to test itself might lead to problems. I think I will create two implementations of the test. One in the setup menu via serial and one via ssh as a self-test of dcu.

👍, but please mark in the documentation that the one used for self-tests can't be used on hardware, or we will have false-positive results in regression tests.