fix: CSimplifiedMNListDiff deser

Author: UdjinM6

src/evo/core_write.cpp

@@ -197,7 +197,7 @@
     ssCbTxMerkleTree << cbTxMerkleTree;
     obj.pushKV("cbTxMerkleTree", HexStr(ssCbTxMerkleTree));
 
-    obj.pushKV("cbTx", EncodeHexTx(*cbTx));
+    obj.pushKV("cbTx", EncodeHexTx(CTransaction(cbTx)));
 
     UniValue deletedMNsArr(UniValue::VARR);
     for (const auto& h : deletedMNs) {
@@ -227,7 +227,7 @@
     obj.pushKV("newQuorums", newQuorumsArr);
 
     // Do not assert special tx type here since this can be called prior to DIP0003 activation
-    if (const auto opt_cbTxPayload = GetTxPayload<CCbTx>(*cbTx, /*assert_type=*/false)) {
+    if (const auto opt_cbTxPayload = GetTxPayload<CCbTx>(cbTx, /*assert_type=*/false)) {
         obj.pushKV("merkleRootMNList", opt_cbTxPayload->merkleRootMNList.ToString());
         if (opt_cbTxPayload->nVersion >= CCbTx::Version::MERKLE_ROOT_QUORUMS) {
             obj.pushKV("merkleRootQuorums", opt_cbTxPayload->merkleRootQuorums.ToString());

src/evo/smldiff.cpp

@@ -209,7 +209,7 @@ bool BuildSimplifiedMNListDiff(CDeterministicMNManager& dmnman, const Chainstate
         return false;
     }
 
-    mnListDiffRet.cbTx = block.vtx[0];
+    mnListDiffRet.cbTx = CMutableTransaction(*block.vtx[0]);
 
     std::vector<uint256> vHashes;
     std::vector<bool> vMatch(block.vtx.size(), false);

src/evo/smldiff.h

@@ -49,7 +49,7 @@ class CSimplifiedMNListDiff
     uint256 baseBlockHash;
     uint256 blockHash;
     CPartialMerkleTree cbTxMerkleTree;
-    CTransactionRef cbTx;
+    CMutableTransaction cbTx;
     std::vector<uint256> deletedMNs;
     std::vector<CSimplifiedMNListEntry> mnList;
     uint16_t nVersion{CURRENT_VERSION};