Merge dashpay#6774: fix: follow-up bitcoin#25680 for several Dash rpcs: newkeypool, dumpprivkey, importelectrumwallet

b27ab96 fix: follow-up bitcoin#25680 for several Dash rpcs: newkeypool, dumpprivkey, importelectrumwallet (Konstantin Akimov)

Pull request description:

  ## Issue being fixed or feature implemented
  These Dash RPCs are legacy-only, but note is missing in dashpay#6747

  ## What was done?
  Added note for `newkeypool`, `dumpprivkey`, `importelectrumwallet`

  ## How Has This Been Tested?
  N/A

  ## Breaking Changes
  N/A

  ## Checklist:
  - [x] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone

ACKs for top commit:
  UdjinM6:
    utACK b27ab96

Tree-SHA512: a0b9c179e691be217511f669e93cf56a9a0182a536d54dcc0f54f3ba436c2b0cff6e078da5c72e39b10a5298ace1640488ac2e0955767ab767ea275b13ffd536

Author: PastaPastaPasta

src/wallet/rpc/addresses.cpp

@@ -314,7 +314,8 @@ RPCHelpMan newkeypool()
                 "When restoring a backup of an HD wallet created before the newkeypool command is run, funds received to\n"
                 "new addresses may not appear automatically. They have not been lost, but the wallet may not find them.\n"
                 "This can be fixed by running the newkeypool command on the backup and then rescanning, so the wallet\n"
-                "re-generates the required keys." +
+                "re-generates the required keys.\n"
+                "Note: This command is only compatible with legacy wallets.\n" +
             HELP_REQUIRING_PASSPHRASE,
                 {},
                 RPCResult{RPCResult::Type::NONE, "", ""},

src/wallet/rpc/backup.cpp

@@ -644,7 +644,8 @@ RPCHelpMan importwallet()
 RPCHelpMan importelectrumwallet()
 {
     return RPCHelpMan{"importelectrumwallet",
-        "\nImports keys from an Electrum wallet export file (.csv or .json)\n",
+        "\nImports keys from an Electrum wallet export file (.csv or .json)\n"
+        "Note: This command is only compatible with legacy wallets.\n",
         {
             {"filename", RPCArg::Type::STR, RPCArg::Optional::NO, "The Electrum wallet export file, should be in csv or json format"},
             {"index", RPCArg::Type::NUM, RPCArg::Default{0}, "Rescan the wallet for transactions starting from this block index"},
@@ -869,7 +870,8 @@ RPCHelpMan dumpprivkey()
 RPCHelpMan dumphdinfo()
 {
     return RPCHelpMan{"dumphdinfo",
-        "Returns an object containing sensitive private info about this HD wallet.\n",
+        "Returns an object containing sensitive private info about this HD wallet.\n"
+        "Note: This command is only compatible with legacy wallets.\n",
         {},
         RPCResult{
                 RPCResult::Type::OBJ, "", "",