fix: misusing m_inventory for ProcessMessageRet

knst · knst · commit 8ec5e2026799 · 2025-09-23T21:47:09.000+07:00
diff --git a/src/net_processing.cpp b/src/net_processing.cpp
@@ -3608,7 +3608,7 @@ MessageProcessingResult PeerManagerImpl::ProcessPlatformBanMessage(NodeId node,
     if (meta_info->SetPlatformBan(true, ban_msg.m_requested_height)) {
         LogPrintf("PLATFORMBAN -- forward message to other nodes\n");
         m_mn_metaman.RememberPlatformBan(hash, std::move(ban_msg));
-        ret.m_inventory = CInv{MSG_PLATFORM_BAN, hash};
+        ret.m_inventory.emplace_back(MSG_PLATFORM_BAN, hash);
     }
     return ret;
 }

Original file line number	Diff line number	Diff line change
`@@ -3608,7 +3608,7 @@ MessageProcessingResult PeerManagerImpl::ProcessPlatformBanMessage(NodeId node,`
`3608`	`3608`	`if (meta_info->SetPlatformBan(true, ban_msg.m_requested_height)) {`
`3609`	`3609`	`LogPrintf("PLATFORMBAN -- forward message to other nodes\n");`
`3610`	`3610`	`m_mn_metaman.RememberPlatformBan(hash, std::move(ban_msg));`
`3611`		`- ret.m_inventory = CInv{MSG_PLATFORM_BAN, hash};`
	`3611`	`+ ret.m_inventory.emplace_back(MSG_PLATFORM_BAN, hash);`
`3612`	`3612`	`}`
`3613`	`3613`	`return ret;`
`3614`	`3614`	`}`