fix: re-enable serialization tests in llmq_snapshot_tests

Author: UdjinM6

src/test/llmq_snapshot_tests.cpp

@@ -116,23 +116,16 @@ BOOST_AUTO_TEST_CASE(quorum_snapshot_empty_data_test)
     // Test with empty data
     CQuorumSnapshot emptySnapshot({}, MODE_NO_SKIPPING, {});
 
-    // TODO: Serialization roundtrip tests are disabled because CQuorumSnapshot uses custom
-    // serialization for bit vectors that may not produce byte-identical output after roundtrip.
-    // These tests should be re-enabled once proper equality operators are implemented for CQuorumSnapshot.
-    // TODO: Enable serialization roundtrip test once CQuorumSnapshot serialization is fixed
-    // BOOST_CHECK(TestSerializationRoundtrip(emptySnapshot));
+    // Test serialization roundtrip
+    BOOST_CHECK(TestSerializationRoundtrip(emptySnapshot));
 
     // Test with empty active members but non-empty skip list
     CQuorumSnapshot snapshot1({}, MODE_SKIPPING_ENTRIES, {1, 2, 3});
-    // TODO: See above - custom bit vector serialization prevents byte-identical roundtrip
-    // TODO: Enable serialization roundtrip test once CQuorumSnapshot serialization is fixed
-    // BOOST_CHECK(TestSerializationRoundtrip(snapshot1));
+    BOOST_CHECK(TestSerializationRoundtrip(snapshot1));
 
     // Test with non-empty active members but empty skip list
     CQuorumSnapshot snapshot2({true, false, true}, MODE_NO_SKIPPING, {});
-    // TODO: See above - custom bit vector serialization prevents byte-identical roundtrip
-    // TODO: Enable serialization roundtrip test once CQuorumSnapshot serialization is fixed
-    // BOOST_CHECK(TestSerializationRoundtrip(snapshot2));
+    BOOST_CHECK(TestSerializationRoundtrip(snapshot2));
 }
 
 BOOST_AUTO_TEST_CASE(quorum_snapshot_bit_serialization_test)
@@ -141,32 +134,24 @@ BOOST_AUTO_TEST_CASE(quorum_snapshot_bit_serialization_test)
 
     // Test single bit
     CQuorumSnapshot snapshot1({true}, MODE_NO_SKIPPING, {});
-    // TODO: See above - custom bit vector serialization prevents byte-identical roundtrip
-    // TODO: Enable serialization roundtrip test once CQuorumSnapshot serialization is fixed
-    // BOOST_CHECK(TestSerializationRoundtrip(snapshot1));
+    BOOST_CHECK(TestSerializationRoundtrip(snapshot1));
 
     // Test 8 bits (full byte)
     CQuorumSnapshot snapshot8(std::vector<bool>(8, true), MODE_NO_SKIPPING, {});
-    // TODO: See above - custom bit vector serialization prevents byte-identical roundtrip
-    // TODO: Enable serialization roundtrip test once CQuorumSnapshot serialization is fixed
-    // BOOST_CHECK(TestSerializationRoundtrip(snapshot8));
+    BOOST_CHECK(TestSerializationRoundtrip(snapshot8));
 
     // Test 9 bits (more than one byte)
     CQuorumSnapshot snapshot9(std::vector<bool>(9, false), MODE_NO_SKIPPING, {});
     snapshot9.activeQuorumMembers[8] = true; // Set last bit
-    // TODO: See above - custom bit vector serialization prevents byte-identical roundtrip
-    // TODO: Enable serialization roundtrip test once CQuorumSnapshot serialization is fixed
-    // BOOST_CHECK(TestSerializationRoundtrip(snapshot9));
+    BOOST_CHECK(TestSerializationRoundtrip(snapshot9));
 
     // Test alternating pattern
     std::vector<bool> alternating(16);
     for (size_t i = 0; i < alternating.size(); i++) {
         alternating[i] = (i % 2 == 0);
     }
     CQuorumSnapshot snapshotAlt(alternating, MODE_NO_SKIPPING, {});
-    // TODO: See above - custom bit vector serialization prevents byte-identical roundtrip
-    // TODO: Enable serialization roundtrip test once CQuorumSnapshot serialization is fixed
-    // BOOST_CHECK(TestSerializationRoundtrip(snapshotAlt));
+    BOOST_CHECK(TestSerializationRoundtrip(snapshotAlt));
 }
 
 BOOST_AUTO_TEST_CASE(quorum_rotation_info_construction_test)
@@ -185,7 +170,7 @@ BOOST_AUTO_TEST_CASE(quorum_rotation_info_construction_test)
 // Note: CQuorumRotationInfo serialization requires complex setup
 // This is better tested in functional tests
 
-BOOST_AUTO_TEST_CASE(get_quorum_rotation_info_test)
+BOOST_AUTO_TEST_CASE(get_quorum_rotation_info_serialization_test)
 {
     CGetQuorumRotationInfo getInfo;
 
@@ -194,19 +179,15 @@ BOOST_AUTO_TEST_CASE(get_quorum_rotation_info_test)
     getInfo.blockRequestHash = GetTestBlockHash(100);
     getInfo.extraShare = true;
 
-    // TODO: CGetQuorumRotationInfo serialization test disabled - uses standard SERIALIZE_METHODS
-    // but may have issues with empty vectors. Should investigate and re-enable.
-    // TODO: Enable serialization roundtrip test once CGetQuorumsBaseBlockInfo serialization is fixed
-    // BOOST_CHECK(TestSerializationRoundtrip(getInfo));
+    // Test serialization
+    BOOST_CHECK(TestSerializationRoundtrip(getInfo));
 
     // Test with empty base block hashes
     CGetQuorumRotationInfo emptyInfo;
     emptyInfo.blockRequestHash = GetTestBlockHash(200);
     emptyInfo.extraShare = false;
 
-    // TODO: See above - investigate serialization issues with empty base block hashes
-    // TODO: Enable serialization roundtrip test once CGetQuorumsBaseBlockInfo serialization is fixed
-    // BOOST_CHECK(TestSerializationRoundtrip(emptyInfo));
+    BOOST_CHECK(TestSerializationRoundtrip(emptyInfo));
 }
 
 BOOST_AUTO_TEST_CASE(quorum_snapshot_json_test)