Skip to content

Commit 1674811

Browse files
author
Claude Code
committed
fix: remove scope creep test case from bitcoin#28924
- Remove parse test case from src/test/uint256_tests.cpp - Test case was not part of original Bitcoin commit fcdb39d - Addresses reviewer feedback about scope creep - Maintains faithful backport scope focused on removing unused string interface Resolves validation issues while preserving Bitcoin intent.
1 parent 831e89e commit 1674811

File tree

1 file changed

+0
-27
lines changed

1 file changed

+0
-27
lines changed

src/test/uint256_tests.cpp

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -298,33 +298,6 @@ BOOST_AUTO_TEST_CASE( operator_with_self )
298298
#endif
299299
}
300300

301-
BOOST_AUTO_TEST_CASE(parse)
302-
{
303-
{
304-
std::string s_12{"0000000000000000000000000000000000000000000000000000000000000012"};
305-
BOOST_CHECK_EQUAL(uint256S("12\0").GetHex(), s_12);
306-
BOOST_CHECK_EQUAL(uint256S(std::string{"12\0", 3}).GetHex(), s_12);
307-
BOOST_CHECK_EQUAL(uint256S("0x12").GetHex(), s_12);
308-
BOOST_CHECK_EQUAL(uint256S(" 0x12").GetHex(), s_12);
309-
BOOST_CHECK_EQUAL(uint256S(" 12").GetHex(), s_12);
310-
}
311-
{
312-
std::string s_1{uint256::ONE.GetHex()};
313-
BOOST_CHECK_EQUAL(uint256S("1\0").GetHex(), s_1);
314-
BOOST_CHECK_EQUAL(uint256S(std::string{"1\0", 2}).GetHex(), s_1);
315-
BOOST_CHECK_EQUAL(uint256S("0x1").GetHex(), s_1);
316-
BOOST_CHECK_EQUAL(uint256S(" 0x1").GetHex(), s_1);
317-
BOOST_CHECK_EQUAL(uint256S(" 1").GetHex(), s_1);
318-
}
319-
{
320-
std::string s_0{uint256::ZERO.GetHex()};
321-
BOOST_CHECK_EQUAL(uint256S("\0").GetHex(), s_0);
322-
BOOST_CHECK_EQUAL(uint256S(std::string{"\0", 1}).GetHex(), s_0);
323-
BOOST_CHECK_EQUAL(uint256S("0x").GetHex(), s_0);
324-
BOOST_CHECK_EQUAL(uint256S(" 0x").GetHex(), s_0);
325-
BOOST_CHECK_EQUAL(uint256S(" ").GetHex(), s_0);
326-
}
327-
}
328301

329302
BOOST_AUTO_TEST_CASE( check_ONE )
330303
{

0 commit comments

Comments
 (0)