Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The IE excavator doesn't yield anything for geolosys minerals #3025

Closed
notpeelz opened this issue Jul 1, 2018 · 6 comments
Closed

The IE excavator doesn't yield anything for geolosys minerals #3025

notpeelz opened this issue Jul 1, 2018 · 6 comments

Comments

@notpeelz
Copy link
Contributor

notpeelz commented Jul 1, 2018

Bug Report

The IE excavator doesn't yield anything for geolosys minerals.
The issue is caused by the registered MineralMix ores not being valid OreDictionary identifiers (i.e. geolosysOreXXX).
Relevant file: src/scripts/ores/excavator.zs

Expected Behaviour

The IE excavator should yield geolosys clusters matching the mineral in the chunk.

Possible Solution

Register the non-existing geolosys OreDictionary identifiers.
e.g.

//Limonite (Iron and Nickel)
Excavator.addMineral("Limonite", 30, 0.15, [], [], [-1], true);
var limonite = Excavator.getMineral("Limonite");

// >> ADD THIS <<
<ore:geolosysOreIron>.add(<geolosys:cluster:0>);
<ore:geolosysOreNickel>.add(<geolosys:cluster:7>);

// `geolosysOreIron` and `geolosysOreNickel` aren't valid OreDictionary identifiers
limonite.addOre("geolosysOreIron", 0.70);
limonite.addOre("geolosysOreNickel", 0.30);

Steps to Reproduce

  1. Locate a chunk containing a geolysis mineral using either the core sample drill or /ie mineral get
  2. Setup an excavator on the said chunk

Logs

N/A

Client Information

  • Modpack Version: 3.0.8

World Information

N/A

@kamyu2
Copy link

kamyu2 commented Jul 1, 2018

Are you identifying the chunk with a core sample drill? The excavator has its own ore map and doesn't care where surface samples or actual ore veins are located.

@notpeelz
Copy link
Contributor Author

notpeelz commented Jul 1, 2018

Yes and I double check with /ie mineral get.

@stale
Copy link

stale bot commented Aug 1, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for reporting to the tracker.

@stale stale bot added the Status: Stale label Aug 1, 2018
@notpeelz
Copy link
Contributor Author

notpeelz commented Aug 1, 2018

Can we merge the PR?

@stale stale bot removed the Status: Stale label Aug 1, 2018
@stale
Copy link

stale bot commented Aug 31, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for reporting to the tracker.

@stale stale bot added the Status: Stale label Aug 31, 2018
@stale
Copy link

stale bot commented Sep 7, 2018

This issue has been marked as stale for a week now with no new responses. As such, it has been automatically closed.

@stale stale bot closed this as completed Sep 7, 2018
@artdude543 artdude543 reopened this Sep 25, 2018
@stale stale bot removed the Status: Stale label Sep 25, 2018
@justinrusso justinrusso added this to the 3.1.0 milestone Mar 7, 2019
phenonymous referenced this issue Mar 9, 2019
* Fix IE excavator not yielding geolosys clusters

* chore: update changelog

* refactor: change oreClusterGeolosys to oreCluster
@lock lock bot locked as resolved and limited conversation to collaborators May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants