Skip to content

Commit

Permalink
highmem: Fix race in debug_kmap_atomic() which could cause warn_count…
Browse files Browse the repository at this point in the history
… to underflow

debug_kmap_atomic() tries to prevent ever printing more than 10
warnings, but it does so by testing whether an unsigned integer
is equal to 0. However, if the warning is caused by a nested
IRQ, then this counter may underflow and the stream of warnings
will never end.

Fix that by using a signed integer instead.

Signed-off-by: Soeren Sandmann Pedersen <sandmann@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: a.p.zijlstra@chello.nl
Cc: <stable@kernel.org> # .31.x
LKML-Reference: <ye8zl7b8ktj.fsf@camel23.daimi.au.dk>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
sorensp authored and Ingo Molnar committed Nov 10, 2009
1 parent 83f5b01 commit 5ebd4c2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions mm/highmem.c
Original file line number Diff line number Diff line change
Expand Up @@ -426,9 +426,9 @@ void __init page_address_init(void)

void debug_kmap_atomic(enum km_type type)
{
static unsigned warn_count = 10;
static int warn_count = 10;

if (unlikely(warn_count == 0))
if (unlikely(warn_count < 0))
return;

if (unlikely(in_interrupt())) {
Expand Down

0 comments on commit 5ebd4c2

Please sign in to comment.