-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: implement integration testing #124
Merged
mgravell
merged 42 commits into
DapperLib:main
from
DeagleGross:dmkorolev/integration-tests
Aug 23, 2024
Merged
chore: implement integration testing #124
mgravell
merged 42 commits into
DapperLib:main
from
DeagleGross:dmkorolev/integration-tests
Aug 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far the only testing available is "eye-testing":
It would be great to have some integration tests using generated bits against some database to ensure code works. I created
Dapper.AOT.Test.Integration
project as a launcher of tests andDapper.AOT.Test.Integration.Executables
project as user code (similar to input we had before).Tests work in this way:
Executables
(I will further call it "user code") and parse the code as textDapperInterceptorGenerator
on that compilation and get new compilation instance with both user code and generated bitscompilation.Emit()
to get a built-in assembly in the codeIDbConnection
.To make sure that generated interception code is actually being invoked, I also adjusted
DapperInterceptorGenerator
to include such a code line:Since
Dapper.AOT.Test.Integration.Executables
assembly is anyway referenced to the compilation built during a test execution, we have access to all types there.InterceptorRecorderResolver
is a container forIInterceptorRecorder
-> test code can register any implementation of recorder to collect all necessary information it can. The implementation I have provided does the following:In such a manner we can be sure that generated code is actually executed.
Closes #122