-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: support DbString in DapperAOT #119
Conversation
add Integration tests for dbstring (in a separate project Dapper.AOT.Test.Integration)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great; there's a ton of work in here, thanks; a couple of minor optional nits, but: massive thanks
Hey @mgravell, regarding testing
|
DbString
is a known type in Dapper and currently there is no dedicated support in DapperAOT for it.Current PR does 2 things regarding
DbString
:DbString
toDbValue
attribute.DbParameter
if one of parameter members isDbString
by setting.Value
,.Size
and.DbType
Implementation notes:
Dapper.AOT.Analyzers
which are copied to the output in separate folderInGeneration
PreGeneratedCodeWriter
), and included the generation context options inGenerateState
to have a control over which pre-generated types to include in the output. I decided to do in order to avoid writingDbStringHelpers
in the output even in those cases, whereDbString
is not even used (basically to have more clear output)Questions:
DbString
inUpdateParameters
? Do we need to call the same setup there, or just re-assigning value is fine?Closes #89