Skip to content

Commit 83d360d

Browse files
committed
build: remove bootstrap and jquery from dev dependencies
1 parent 33cd47c commit 83d360d

File tree

5 files changed

+6
-47
lines changed

5 files changed

+6
-47
lines changed

package.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,6 @@
123123
"autoprefixer": "10.4.19",
124124
"babel-loader": "9.1.3",
125125
"babel-plugin-istanbul": "6.1.1",
126-
"bootstrap": "^4.0.0",
127126
"browser-sync": "3.0.2",
128127
"browserslist": "^4.21.5",
129128
"buffer": "6.0.3",
@@ -149,7 +148,6 @@
149148
"jasmine": "^5.0.0",
150149
"jasmine-core": "~5.1.0",
151150
"jasmine-spec-reporter": "~7.0.0",
152-
"jquery": "^3.3.1",
153151
"jsonc-parser": "3.2.1",
154152
"karma": "~6.4.0",
155153
"karma-chrome-launcher": "~3.2.0",
@@ -176,7 +174,6 @@
176174
"patch-package": "^7.0.1",
177175
"picomatch": "4.0.2",
178176
"piscina": "4.4.0",
179-
"popper.js": "^1.14.1",
180177
"postcss": "8.4.38",
181178
"postcss-loader": "8.1.1",
182179
"prettier": "^3.0.0",

packages/angular_devkit/build_angular/BUILD.bazel

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -357,9 +357,6 @@ LARGE_SPECS = {
357357
"extra_deps": [
358358
"@npm//@angular/animations",
359359
"@npm//@angular/material",
360-
"@npm//bootstrap",
361-
"@npm//jquery",
362-
"@npm//popper.js",
363360
],
364361
},
365362
"prerender": {},

packages/angular_devkit/build_angular/src/builders/browser/specs/styles_spec.ts

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -442,26 +442,6 @@ describe('Browser Builder styles', () => {
442442
4 * 60 * 1000,
443443
);
444444

445-
it(`supports bootstrap@4 with full path`, async () => {
446-
const bootstrapPath = dirname(require.resolve('bootstrap/package.json'));
447-
448-
const overrides = {
449-
styles: [bootstrapPath + '/dist/css/bootstrap.css'],
450-
scripts: [bootstrapPath + '/dist/js/bootstrap.js'],
451-
};
452-
453-
await browserBuild(architect, host, target, overrides);
454-
});
455-
456-
it(`supports bootstrap@4 with package reference`, async () => {
457-
const overrides = {
458-
styles: ['bootstrap/dist/css/bootstrap.css'],
459-
scripts: ['bootstrap/dist/js/bootstrap.js'],
460-
};
461-
462-
await browserBuild(architect, host, target, overrides);
463-
});
464-
465445
it(`supports inline javascript in less`, async () => {
466446
const overrides = { styles: [`src/styles.less`] };
467447
host.writeMultipleFiles({

packages/angular_devkit/build_angular/src/builders/browser/tests/options/allowed-common-js-dependencies_spec.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ describeBuilder(buildWebpackBrowser, BROWSER_BUILDER_INFO, (harness) => {
1818
aot ? 'AOT' : 'JIT'
1919
} Mode`, async () => {
2020
// Add a Common JS dependency
21-
await harness.appendToFile('src/app/app.component.ts', `import 'bootstrap';`);
21+
await harness.appendToFile('src/app/app.component.ts', `import 'ajv';`);
2222

2323
harness.useTarget('build', {
2424
...BASE_OPTIONS,
@@ -32,13 +32,13 @@ describeBuilder(buildWebpackBrowser, BROWSER_BUILDER_INFO, (harness) => {
3232
expect(logs).toContain(
3333
jasmine.objectContaining<logging.LogEntry>({
3434
message: jasmine.stringMatching(
35-
/Warning: .+app\.component\.ts depends on 'bootstrap'\. CommonJS or AMD dependencies/,
35+
/Warning: .+app\.component\.ts depends on 'ajv'\. CommonJS or AMD dependencies/,
3636
),
3737
}),
3838
);
3939
expect(logs).not.toContain(
4040
jasmine.objectContaining<logging.LogEntry>({
41-
message: jasmine.stringMatching('jquery'),
41+
message: jasmine.stringMatching('require-from-string'),
4242
}),
4343
'Should not warn on transitive CommonJS packages which parent is also CommonJS.',
4444
);
@@ -51,14 +51,14 @@ describeBuilder(buildWebpackBrowser, BROWSER_BUILDER_INFO, (harness) => {
5151
await harness.appendToFile(
5252
'src/app/app.component.ts',
5353
`
54-
import 'bootstrap';
54+
import 'ajv';
5555
import 'zone.js';
5656
`,
5757
);
5858

5959
harness.useTarget('build', {
6060
...BASE_OPTIONS,
61-
allowedCommonJsDependencies: ['bootstrap', 'zone.js'],
61+
allowedCommonJsDependencies: ['ajv', 'zone.js'],
6262
});
6363

6464
const { result, logs } = await harness.executeOnce();
@@ -76,7 +76,7 @@ describeBuilder(buildWebpackBrowser, BROWSER_BUILDER_INFO, (harness) => {
7676
await harness.appendToFile(
7777
'src/app/app.component.ts',
7878
`
79-
import 'bootstrap';
79+
import 'ajv';
8080
import 'zone.js';
8181
`,
8282
);

yarn.lock

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -5466,11 +5466,6 @@ boolbase@^1.0.0:
54665466
resolved "https://registry.yarnpkg.com/boolbase/-/boolbase-1.0.0.tgz#68dff5fbe60c51eb37725ea9e3ed310dcc1e776e"
54675467
integrity sha512-JZOSA7Mo9sNGB8+UjSgzdLtokWAky1zbztM3WRLCbZ70/3cTANmQmOdR7y2g+J0e2WXywy1yS468tY+IruqEww==
54685468

5469-
bootstrap@^4.0.0:
5470-
version "4.6.2"
5471-
resolved "https://registry.yarnpkg.com/bootstrap/-/bootstrap-4.6.2.tgz#8e0cd61611728a5bf65a3a2b8d6ff6c77d5d7479"
5472-
integrity sha512-51Bbp/Uxr9aTuy6ca/8FbFloBUJZLHwnhTcnjIeRn2suQWsWzcuJhGjKDB5eppVte/8oCdOL3VuwxvZDUggwGQ==
5473-
54745469
brace-expansion@^1.1.7:
54755470
version "1.1.11"
54765471
resolved "https://registry.yarnpkg.com/brace-expansion/-/brace-expansion-1.1.11.tgz#3c7fcbf529d87226f3d2f52b966ff5271eb441dd"
@@ -9042,11 +9037,6 @@ jju@~1.4.0:
90429037
resolved "https://registry.yarnpkg.com/jju/-/jju-1.4.0.tgz#a3abe2718af241a2b2904f84a625970f389ae32a"
90439038
integrity sha512-8wb9Yw966OSxApiCt0K3yNJL8pnNeIv+OEq2YMidz4FKP6nonSRoOXc80iXY4JaN2FC11B9qsNmDsm+ZOfMROA==
90449039

9045-
jquery@^3.3.1:
9046-
version "3.7.1"
9047-
resolved "https://registry.yarnpkg.com/jquery/-/jquery-3.7.1.tgz#083ef98927c9a6a74d05a6af02806566d16274de"
9048-
integrity sha512-m4avr8yL8kmFN8psrbFFFmB/If14iN5o9nw/NgnnM+kybDJpRsAynV2BsfpTYrTRysYUdADVD7CkUUizgkpLfg==
9049-
90509040
js-base64@^3.7.7:
90519041
version "3.7.7"
90529042
resolved "https://registry.yarnpkg.com/js-base64/-/js-base64-3.7.7.tgz#e51b84bf78fbf5702b9541e2cb7bfcb893b43e79"
@@ -11344,11 +11334,6 @@ pluralize@^8.0.0:
1134411334
resolved "https://registry.yarnpkg.com/pluralize/-/pluralize-8.0.0.tgz#1a6fa16a38d12a1901e0320fa017051c539ce3b1"
1134511335
integrity sha512-Nc3IT5yHzflTfbjgqWcCPpo7DaKy4FnpB0l/zCAW0Tc7jxAiuqSxHasntB3D7887LSrA93kDJ9IXovxJYxyLCA==
1134611336

11347-
popper.js@^1.14.1:
11348-
version "1.16.1"
11349-
resolved "https://registry.yarnpkg.com/popper.js/-/popper.js-1.16.1.tgz#2a223cb3dc7b6213d740e40372be40de43e65b1b"
11350-
integrity sha512-Wb4p1J4zyFTbM+u6WuO4XstYx4Ky9Cewe4DWrel7B0w6VVICvPwdOpotjzcf6eD8TsckVnIMNONQyPIUFOUbCQ==
11351-
1135211337
portfinder@^1.0.32:
1135311338
version "1.0.32"
1135411339
resolved "https://registry.yarnpkg.com/portfinder/-/portfinder-1.0.32.tgz#2fe1b9e58389712429dc2bea5beb2146146c7f81"

0 commit comments

Comments
 (0)