Skip to content

Commit 1582bdc

Browse files
committed
Cleaned up logging code
1 parent 98df2d4 commit 1582bdc

File tree

1 file changed

+14
-32
lines changed

1 file changed

+14
-32
lines changed

s.py

Lines changed: 14 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,9 @@
3232

3333
# custom say hello command
3434
def log(message):
35+
timestamp = str(strftime("[%d %b %Y - %H:%M:%S]", gmtime()))
3536
f = open("Logs/chat_log_"+ dateString +".txt","a+")
36-
f.write(message)
37+
f.write(timestamp+" "+message+"\n")
3738
f.close()
3839
def getTimestamp():
3940
time = strftime("[%H:%M:%S]", gmtime())
@@ -99,7 +100,8 @@ def stripHash(data):
99100
date = strftime("%a_%d_%b_%Y", gmtime())
100101
dateString = str(date)
101102
print("Server started.")
102-
log("Server started at " + timestamp +"\n")
103+
log("\n\n-----------------------------------------"+"Server started at "+str(strftime("[%d %b %Y - %H:%M:%S]", gmtime()))
104+
+"-----------------------------------------")
103105

104106
def parseInput(data, con):
105107
global buffer
@@ -134,11 +136,8 @@ def parseInput(data, con):
134136
con.send(hashData('<close>'))
135137
if usernameTaken == 0:
136138
clients[newclient] = con
137-
timestamp = getTimestamp()
138-
date = strftime("%a_%d_%b_%Y", gmtime())
139-
dateString = str(date)
140139
messageAll(hashData(messageInfo("[ANNOUNCEMENT] New client "+newclient+" connected. Welcome to \'"+getChatName()+"\'!")))
141-
log("New client "+newclient+" at "+ getTimestamp() +"\n")
140+
log("New client \'"+newclient+"\' connected")
142141

143142
elif "<changenickname " in data: #<changenick Daniel>
144143
oldnick = getClientName(con)
@@ -148,12 +147,8 @@ def parseInput(data, con):
148147
newnick = splitMessage[1]
149148
del clients[getClientName(con)] #Removes client value
150149
clients[newnick] = con # Adds a client value based on new nickname
151-
timestamp = getTimestamp()
152-
date = strftime("%a_%d_%b_%Y", gmtime())
153-
dateString = str(date)
154-
log("Nickname changed to " + newnick + " By "+ oldnick +" at "+ timestamp +"\n")
155-
156-
messageAll(hashData(messageInfo(oldnick+" has changed their nickname to \'"+newnick+"\'." )))
150+
log("Nickname changed to " + newnick + " By "+ oldnick)
151+
messageAll(hashData(messageInfo(oldnick+" has changed their nickname to \'"+newnick+"\'" )))
157152
elif "<chat>" in data: # <msg>Daniel~This is a message</msg>
158153
timestamp = getTimestamp()
159154
tagless = data[6:-7]
@@ -162,23 +157,14 @@ def parseInput(data, con):
162157
user = splitMessage[0]
163158
message = splitMessage[1]
164159
print("Message received")
165-
date = strftime("%a_%d_%b_%Y", gmtime())
166-
dateString = str(date)
167-
log("Message : "+timestamp+" "+user+": " + message + "\n")
160+
log("Message : "+user+": " + message)
168161
messageAll(hashData(messageMsg(timestamp+" "+user+": " + message)))
169162
elif "<ping>" in data:
170-
timestamp = getTimestamp()
171-
date = strftime("%a_%d_%b_%Y", gmtime())
172-
dateString = str(date)
173-
log("Server pinged at " + timestamp +"\n")
174-
175163
con.send(hashData("<pong>"))
164+
log("Server pinged by " + getClientName(con))
176165
elif "<connected>" in data:
177-
timestamp = getTimestamp()
178-
date = strftime("%a_%d_%b_%Y", gmtime())
179-
dateString = str(date)
180-
log("Connection list called at " + timestamp +" List Value "+ getClientList() +"\n")
181166
con.send(hashData(messageInfo(getClientList())))
167+
log("Connection list called. "+ getClientList())
182168
elif "<kick " in data:
183169
kicker = getClientName(con)
184170
tagless = data[1:-1]
@@ -188,13 +174,11 @@ def parseInput(data, con):
188174
usercon = getClientCon(user)
189175
usercon.send(hashData(messageInfo("[ANNOUNCEMENT] You have been kicked by "+kicker+".")))
190176
usercon.send('<close>')
191-
timestamp = getTimestamp()
192-
date = strftime("%a_%d_%b_%Y", gmtime())
193-
dateString = str(date)
194-
log(user + " Kicked from Chat at " + timestamp + " by "+ kicker +"\n")
195177
messageAll(hashData(messageInfo("[ANNOUNCEMENT] \'"+user+"\' has been kicked from the chat by \'"+kicker+"\'.")))
196178
del clients[user]
197179
currentConnections.remove(usercon)
180+
log(user + " has been kicked from the chat by "+ kicker)
181+
198182
elif "<messages>" in data:
199183
con.send(hashData(messageInfo("Message count: "+str(getMessageCount()))))
200184
elif "<roomname>" in data:
@@ -204,11 +188,9 @@ def parseInput(data, con):
204188
user = getClientName(con)
205189
newname = data[16:-1]
206190
setChatName(newname)
207-
timestamp = getTimestamp()
208-
date = strftime("%a_%d_%b_%Y", gmtime())
209-
dateString = str(date)
210-
log("Chat Room name changed to " + newname + " at "+ timestamp +"\n")
211191
messageAll(hashData(messageInfo("[ANNOUNCEMENT] The room name has been changed from \'"+oldname+"\' to \'"+newname+"\' by "+user+".")))
192+
log("Chat room name changed from " + oldname + " to "+newname+" by "+user)
193+
212194
else:
213195
if debug == 1:
214196
print("[DEBUG] Hashes do not match!")

0 commit comments

Comments
 (0)