Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning on c++20 build (emscripten) #275

Closed
caxapexac opened this issue Aug 26, 2022 · 5 comments
Closed

Warning on c++20 build (emscripten) #275

caxapexac opened this issue Aug 26, 2022 · 5 comments
Assignees

Comments

@caxapexac
Copy link

In file included from include/reactphysics3d/reactphysics3d.h:42:
In file included from include\reactphysics3d/engine/PhysicsCommon.h:31:
In file included from include\reactphysics3d/engine/PhysicsWorld.h:45:
include\reactphysics3d/collision/OverlapCallback.h:99:30: warning: explicitly defaulted copy assignment operator is implicitly deleted [-Wdefaulted-function-deleted]
                OverlapPair& operator=(const OverlapPair& contactPair) = default;
                             ^
include\reactphysics3d/collision/OverlapCallback.h:78:30: note: copy assignment operator of 'OverlapPair' is implicitly deleted because field 'mContactPair' is of reference type 'reactphysics3d::ContactPair &'
                ContactPair& mContactPair;

I can provide any additional info which could help to locate this warning build configuration, is it needed?

@DanielChappuis
Copy link
Owner

Thanks for reporting this. I will try to fix this in the next release.

@DanielChappuis DanielChappuis self-assigned this Aug 30, 2022
@DanielChappuis DanielChappuis added this to the Release v1.0.0 milestone Aug 30, 2022
@caxapexac
Copy link
Author

Oh huge thanks for such a speed :)

@DanielChappuis
Copy link
Owner

This is now fixed in version v0.10.0 of the library. Thanks a lot for reporting the issue.

@caxapexac
Copy link
Author

caxapexac commented Mar 10, 2024

@DanielChappuis thanks for the fix. Btw several days ago I've tried to update myself to the develop branch of the engine because of #366
But ended up making those iterator changes manually instead of updating (updating to 'develop' caused another different crash to happen). I'll create the issue on a new crash as soon as I get some time (it didn't crash on a current release, something on a broad phase probably iirc, when I forcefully change the translation of an object while it has a contactpair with another object)

@DanielChappuis
Copy link
Owner

@caxapexac Yes, if you could open a new issue with a stack trace, it would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants