Commit f896e48
committed
workspace=docker: Improve image verification logic
When using workspace=docker, if Skeema finds a pre-existing container created
from a previous run, the image of the container is verified. The previous
logic was overly strict, erroring in two valid situations:
* If the local Docker tag for the major.minor version now points to a
different patch release, due to other non-Skeema Docker usage on the system
* If the version of Docker is several years old and uses the previous
hashing scheme for image identification
In either of these cases, Skeema no longer errors, as long as the Dockerized
instance's flavor (vendor and major.minor version) can be introspected and
correctly match that of the desired image (via Skeema's flavor option).1 parent 6eef627 commit f896e48
6 files changed
+25
-18
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | 11 | | |
13 | 12 | | |
14 | 13 | | |
| |||
134 | 133 | | |
135 | 134 | | |
136 | 135 | | |
137 | | - | |
| 136 | + | |
138 | 137 | | |
139 | 138 | | |
140 | 139 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments