Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signIn/signOut broken due to SvelteKit update #99

Closed
leovoon opened this issue Jul 17, 2022 · 4 comments
Closed

signIn/signOut broken due to SvelteKit update #99

leovoon opened this issue Jul 17, 2022 · 4 comments

Comments

@leovoon
Copy link
Contributor

leovoon commented Jul 17, 2022

Recent sveltekit updates break endpoints https://github.com/sveltejs/kit/blob/master/packages/kit/CHANGELOG.md

@leovoon leovoon closed this as not planned Won't fix, can't repro, duplicate, stale Jul 18, 2022
@leovoon leovoon reopened this Jul 18, 2022
@leovoon
Copy link
Contributor Author

leovoon commented Jul 18, 2022

#100 A pull request is opened to fix the issue.

@leovoon leovoon closed this as completed Jul 18, 2022
@leovoon leovoon reopened this Jul 18, 2022
@leovoon leovoon changed the title signOut broken due to SvelteKit update signIn/signOut broken due to SvelteKit update Jul 18, 2022
@caiges
Copy link

caiges commented Jul 31, 2022

@leovoon is signout working against these new changes? I'm using the main branch of sk-auth and seeing HTTP 405 on POST http://localhost:3000/api/auth/signout and an accompanying error:

Uncaught (in promise) SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data

I'll have to take a deeper look myself.

@leovoon
Copy link
Contributor Author

leovoon commented Jul 31, 2022

@leovoon is signout working against these new changes? I'm using the main branch of sk-auth and seeing HTTP 405 on POST http://localhost:3000/api/auth/signout and an accompanying error:

Uncaught (in promise) SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data

I'll have to take a deeper look myself.

I have no issues with it. As the PR has been merged, I might as well close this issue. You may open one of your own.

@leovoon leovoon closed this as completed Jul 31, 2022
@caiges
Copy link

caiges commented Jul 31, 2022

I had aliased get and post imports from SvelteKitAuth due to changes in SvelteKit which were addressed with the merge. 🥂 thanks for that fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants