update to latest debian and mysql client, remove SCHEDULE/go-cron

Author: justincarter

Dockerfile

@@ -1,11 +1,7 @@
-FROM alpine:latest
-LABEL maintainer="Johannes Schickling <schickling.j@gmail.com>"
-
-ADD install.sh install.sh
-RUN sh install.sh && rm install.sh
+FROM debian:latest
 
 ENV MYSQLDUMP_OPTIONS --quote-names --quick --add-drop-table --add-locks --allow-keywords --disable-keys --extended-insert --single-transaction --create-options --comments --net_buffer_length=16384
-ENV MYSQLDUMP_DATABASE --all-databases
+ENV MYSQLDUMP_DATABASE **None**
 ENV MYSQL_HOST **None**
 ENV MYSQL_PORT 3306
 ENV MYSQL_USER **None**
@@ -19,9 +15,17 @@ ENV S3_S3V4 no
 ENV S3_PREFIX 'backup'
 ENV S3_FILENAME **None**
 ENV MULTI_FILES no
-ENV SCHEDULE **None**
 
-ADD run.sh run.sh
-ADD backup.sh backup.sh
+# install mysqldump, pip, awscli
+RUN apt-get update && \
+	apt-get install -y mariadb-client-10.3 python3 python3-pip && \
+	pip3 install awscli && \
+	apt-get autoremove -y && \
+	apt-get remove -y python3-pip && \
+	apt-get clean && \
+	rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*
+
+ADD run.sh backup.sh /
+RUN chmod +x /run.sh /backup.sh
 
-CMD ["sh", "run.sh"]
+CMD ["sh", "/run.sh"]

README.md

@@ -2,7 +2,9 @@
 
 # mysql-backup-s3
 
-Backup MySQL to S3 (supports periodic backups & mutli files)
+Backup MySQL to S3 (supports periodic backups & mutli files).
+
+Updated to use a Debian base image with the latest MySQL Client tools, removed support for `SCHEDULE` using go-cron.
 
 ## Basic usage
 
@@ -27,10 +29,4 @@ $ docker run -e S3_ACCESS_KEY_ID=key -e S3_SECRET_ACCESS_KEY=secret -e S3_BUCKET
 - `S3_ENDPOINT` the AWS Endpoint URL, for S3 Compliant APIs such as [minio](https://minio.io) (default: none)
 - `S3_S3V4` set to `yes` to enable AWS Signature Version 4, required for [minio](https://minio.io) servers (default: no)
 - `MULTI_FILES` Allow to have one file per database if set `yes` default: no)
-- `SCHEDULE` backup schedule time, see explainatons below
-
-### Automatic Periodic Backups
-
-You can additionally set the `SCHEDULE` environment variable like `-e SCHEDULE="@daily"` to run the backup automatically.
 
-More information about the scheduling can be found [here](http://godoc.org/github.com/robfig/cron#hdr-Predefined_schedules).

backup.sh

@@ -15,6 +15,11 @@ if [ "${S3_BUCKET}" == "**None**" ]; then
   exit 1
 fi
 
+if [ "${MYSQLDUMP_DATABASE}" == "**None**" ]; then
+  echo "You need to set the MYSQLDUMP_DATABASE environment variable (database name OR --all-databases)."
+  exit 1
+fi
+
 if [ "${MYSQL_HOST}" == "**None**" ]; then
   echo "You need to set the MYSQL_HOST environment variable."
   exit 1

install.sh

@@ -6,8 +6,4 @@ if [ "${S3_S3V4}" = "yes" ]; then
     aws configure set default.s3.signature_version s3v4
 fi
 
-if [ "${SCHEDULE}" = "**None**" ]; then
-  sh backup.sh
-else
-  exec go-cron "$SCHEDULE" /bin/sh backup.sh
-fi
+sh backup.sh