Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added handling for extracting error information when a session could not be created #131

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Added handling for extracting error information when a session could not be created #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions src/redfish/rest/v1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ class InvalidCredentialsError(Exception):
"""Raised when invalid credentials have been provided."""
pass

class SessionCreationError(Exception):
"""Raised when a session could not be created."""
pass

class ServerDownOrUnreachableError(Exception):
"""Raised when server is unreachable."""
pass
Expand Down Expand Up @@ -929,9 +933,8 @@ def login(self, username=None, password=None, auth=AuthMethod.SESSION):
respvalidate = self._rest_request(self.login_url, headers=headers)

if respvalidate.status == 401:
#If your REST client has a delay for fail attempts add it here
delay = 0
raise InvalidCredentialsError(delay)
# Invalid credentials supplied
raise InvalidCredentialsError('HTTP 401 Unauthorized returned: Invalid credentials supplied')
elif auth == AuthMethod.SESSION:
data = dict()
data['UserName'] = self.__username
Expand All @@ -947,9 +950,20 @@ def login(self, username=None, password=None, auth=AuthMethod.SESSION):
self.__session_location = resp.session_location

if not self.__session_key and resp.status not in [200, 201, 202, 204]:
#If your REST client has a delay for fail attempts added it here
delay = 0
raise InvalidCredentialsError(delay)
if resp.status == 401:
# Invalid credentials supplied
raise InvalidCredentialsError('HTTP 401 Unauthorized returned: Invalid credentials supplied')
else:
# Other type of error during session creation
error_str = resp.text
try:
error_str = resp.dict["error"]["@Message.ExtendedInfo"][0]["Message"]
except:
try:
error_str = resp.dict["error"]["message"]
except:
pass
raise SessionCreationError('HTTP {}: Failed to created the session\n{}'.format(resp.status, error_str))
else:
self.set_username(None)
self.set_password(None)
Expand Down