Skip to content

Commit 30e2862

Browse files
Merge pull request #37 from DMS-SMS/master
hotfix on v.1.0.3 synchronize
2 parents 7a00a6e + f51ac48 commit 30e2862

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

main.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -236,6 +236,7 @@ func main() {
236236
middleware.GinHResponseWriter(), // change ResponseWriter in *gin.Context to custom writer overriding that (add in v.1.0.3)
237237
middleware.TracerSpanStarter(apiTracer), // start, end top span of tracer & set log, tag about response (add in v.1.0.3)
238238
)
239+
router.Validator = validator.New()
239240

240241
// routing auth service API
241242
authRouter := router.CustomGroup("/", middleware.LogEntrySetter(authLogger))

middleware/request_validator.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,16 +50,16 @@ func (r *requestValidator) RequestValidator(h gin.HandlerFunc) gin.HandlerFunc {
5050
}
5151

5252
switch req.(type) {
53-
case entity.GetScheduleRequest, entity.GetTimeTableRequest:
53+
case *entity.GetScheduleRequest, *entity.GetTimeTableRequest:
5454
if err := c.ShouldBindUri(req); err != nil {
5555
respFor400["code"] = code.FailToBindRequestToStruct
5656
respFor400["message"] = fmt.Sprintf("failed to bind uri in request into golang struct, err: %v", err)
5757
c.AbortWithStatusJSON(http.StatusBadRequest, respFor400)
5858
return
5959
}
60-
case entity.GetClubsSortByUpdateTimeRequest, entity.GetRecruitmentsSortByCreateTimeRequest, entity.GetStudentOutingsRequest,
61-
entity.GetOutingWithFilterRequest, entity.GetAnnouncementsRequest, entity.GetPlaceWithNaverOpenAPIRequest,
62-
entity.GetStudentUUIDsWithInformRequest, entity.GetTeacherUUIDsWithInformRequest, entity.GetParentUUIDsWithInformRequest:
60+
case *entity.GetClubsSortByUpdateTimeRequest, *entity.GetRecruitmentsSortByCreateTimeRequest, *entity.GetStudentOutingsRequest,
61+
*entity.GetOutingWithFilterRequest, *entity.GetAnnouncementsRequest, *entity.GetPlaceWithNaverOpenAPIRequest,
62+
*entity.GetStudentUUIDsWithInformRequest, *entity.GetTeacherUUIDsWithInformRequest, *entity.GetParentUUIDsWithInformRequest:
6363
if err := c.ShouldBindQuery(req); err != nil {
6464
respFor400["code"] = code.FailToBindRequestToStruct
6565
respFor400["message"] = fmt.Sprintf("failed to bind query parameter in request into golang struct, err: %v", err)
@@ -106,7 +106,7 @@ func (r *requestValidator) RequestValidator(h gin.HandlerFunc) gin.HandlerFunc {
106106
}
107107

108108
switch req.(type) {
109-
case *entity.GetStudentUUIDsWithInformRequest, *entity.GetTeacherUUIDsWithInformRequest, *entity.GetParentUUIDsWithInformRequest:
109+
case **entity.GetStudentUUIDsWithInformRequest, **entity.GetTeacherUUIDsWithInformRequest, **entity.GetParentUUIDsWithInformRequest:
110110
emptyValue := reflect.New(reflect.TypeOf(req).Elem()).Elem().Interface()
111111
if reflect.DeepEqual(reflect.ValueOf(req).Elem().Interface(), emptyValue) {
112112
respFor400["code"] = code.IntegrityInvalidRequest

0 commit comments

Comments
 (0)