Refactor Conditional Questions Tests #3522
Draft
+375
−648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-I'm not sure why, but the `:radio_button` type was missing from several remove_list: values. This change adds it to all of the remove_list arrays.
Please add. That was a slip up on my part. |
- The `expect(page).to have_text('Answered just now')` was could not be relied upon to perform the desired check for the saved answer. This is because 'Answered just now' is rendered for many answers on the page, rather than just the newly answered one.
- This change also removes all `click_button 'Save'` executions. This code already appears to be absent from some saved answers. In addition, all of the saves seem to be auto-executed so this change makes the tests more consistent and removes redundancy.
- Some refactoring has also been performed.
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
spec/features/questions/conditions_questions_spec.rbandspec/controllers/answers_controller_with_conditional_questions_spec.rb. This PR attempts to refactor those files by applying DRY principles.spec/support/helpers/conditional_questions_helper.rbhas been created to facilitate the shared logic between the two aforementioned files.@non_conditional_questions[:radiobutton][index].idto someremove_data:values. (I am not sure why these:radiobuttonoptions were absent in the first place and could add them back if needed.)