Match config.load_defaults Version to Rails Version

[aaronskiba]

Changes proposed in this PR:

• Updated config.load_defaults value to 7.1 to match our Rails version.
• Added explicit coder: YAML to serialize calls to conform with Rails 7.1 changes
  • (Prior to Rails 7.1, config.active_record.default_column_serializer = YAML was implicit, so these explicit calls were unnecessary.)

[johnpinto1]

@aaronskiba I wonder if this file https://github.com/rails/rails/blob/v7.0.0/railties/lib/rails/generators/rails/app/templates/config/initializers/new_framework_defaults_7_0.rb.tt (with .tt remove) should be included in config/initializers for completenes. So config commented out config can be switched on if necessary.

[johnpinto1]

@aaronskiba The Condition coder: YAML will need to be be overridden by PR CDLUC3#667 (or the Conditional questions will fail as we moved from YAML to JSON.

roadmap/app/models/condition.rb

Lines 29 to 33 in 76cc7eb

	belongs_to :question
	enum action_type: %i[remove add_webhook]
	serialize :option_list, type: Array, coder: YAML
	serialize :remove_data, type: Array, coder: YAML
	serialize :webhook_data, coder: JSON

Also this change is incorrect it should (as is currently)
serialize :prefs, type: Hash, coder: JSON

roadmap/app/models/user.rb

Lines 72 to 74 in 76cc7eb

	# User Notification Preferences
	serialize :prefs, type: Hash, coder: YAML

[aaronskiba]

@aaronskiba The Condition coder: YAML will need to be be overridden by PR CDLUC3#667 (or the Conditional questions will fail as we moved from YAML to JSON.

roadmap/app/models/condition.rb

Lines 29 to 33 in 76cc7eb

	belongs_to :question
	enum action_type: %i[remove add_webhook]
	serialize :option_list, type: Array, coder: YAML
	serialize :remove_data, type: Array, coder: YAML
	serialize :webhook_data, coder: JSON

Also this change is incorrect it should (as is currently)
serialize :prefs, type: Hash, coder: JSON

roadmap/app/models/user.rb

Lines 72 to 74 in 76cc7eb

	# User Notification Preferences
	serialize :prefs, type: Hash, coder: YAML

Thank you. Yes, the PR you mentioned will migrate those serialized columns from YAML to JSON. We'll have to be sure we end up with the JSON type in the end.

I'm wondering what to do with the other code you mentioned:

 # User Notification Preferences 
 serialize :prefs, type: Hash, coder: YAML

The prefs column isn't actually part of the users table. Based on that, I don't think the code serves any purpose.

Here's a bit of additional information too:

rb(main):0015> user.pref
  Pref Load (0.4ms)  SELECT "prefs".* FROM "prefs" WHERE "prefs"."user_id" = $1 LIMIT $2

class Pref < ApplicationRecord
  ##
  # Serialize prefs to JSON
  serialize :settings, coder: JSON

has_one :pref exists in the User model. user.pref loads the data from that table and settings is correctly set to JSON.

[aaronskiba]

Hi @briri, does it look like this code could be removed entirely? I can see an older migration that moved prefs to its own table, so I'm thinking this code no longer serves a purpose (https://github.com/DMPRoadmap/roadmap/blob/main/db/migrate/20170712084314_move_prefs_to_table.rb).

[briri]

Yeah, I think so. There's a Pref model now and separate table and I don't see anywhere where user.prefs is being accessed