Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix df.talk_choice_type def not being up to date for internal/convo.lua #1380

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

Crystalwarrior
Copy link
Contributor

This also fixes the extra options not appearing in the conversation menu in the "Ask directions" screen

…convo option, resulting in a nil value being passed
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you add a changelog entry?

@Crystalwarrior
Copy link
Contributor Author

@myk002 ah heck I forgot 😭
Can you make a pr template for this repository so any contributors get immediately reminded of that standard? In the meantime I'll only be able to make the change log in like 13 or so hours.

@myk002 myk002 merged commit 4f0a2ca into DFHack:master Jan 27, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants