Skip to content

Commit 4bb95f4

Browse files
egrumbachjmberg-intel
authored andcommitted
wifi: iwlwifi: mvm: don't read past the mfuart notifcation
In case the firmware sends a notification that claims it has more data than it has, we will read past that was allocated for the notification. Remove the print of the buffer, we won't see it by default. If needed, we can see the content with tracing. This was reported by KFENCE. Fixes: bdccdb8 ("iwlwifi: mvm: support MFUART dump in case of MFUART assert") Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com> Reviewed-by: Johannes Berg <johannes.berg@intel.com> Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com> Link: https://msgid.link/20240513132416.ba82a01a559e.Ia91dd20f5e1ca1ad380b95e68aebf2794f553d9b@changeid Signed-off-by: Johannes Berg <johannes.berg@intel.com>
1 parent e6dd293 commit 4bb95f4

File tree

1 file changed

+0
-10
lines changed
  • drivers/net/wireless/intel/iwlwifi/mvm

1 file changed

+0
-10
lines changed

drivers/net/wireless/intel/iwlwifi/mvm/fw.c

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -94,20 +94,10 @@ void iwl_mvm_mfu_assert_dump_notif(struct iwl_mvm *mvm,
9494
{
9595
struct iwl_rx_packet *pkt = rxb_addr(rxb);
9696
struct iwl_mfu_assert_dump_notif *mfu_dump_notif = (void *)pkt->data;
97-
__le32 *dump_data = mfu_dump_notif->data;
98-
int n_words = le32_to_cpu(mfu_dump_notif->data_size) / sizeof(__le32);
99-
int i;
10097

10198
if (mfu_dump_notif->index_num == 0)
10299
IWL_INFO(mvm, "MFUART assert id 0x%x occurred\n",
103100
le32_to_cpu(mfu_dump_notif->assert_id));
104-
105-
for (i = 0; i < n_words; i++)
106-
IWL_DEBUG_INFO(mvm,
107-
"MFUART assert dump, dword %u: 0x%08x\n",
108-
le16_to_cpu(mfu_dump_notif->index_num) *
109-
n_words + i,
110-
le32_to_cpu(dump_data[i]));
111101
}
112102

113103
static bool iwl_alive_fn(struct iwl_notif_wait_data *notif_wait,

0 commit comments

Comments
 (0)