#1934: Update comments and test for lb_data_retention

Co-authored-by: Cezary Skrzyński <cezary.skrzynski@ng-analytics.com>

Author: thearusable

src/vt/vrt/collection/balance/node_lb_data.h

@@ -250,9 +250,9 @@ struct NodeLBData : runtime::component::Component<NodeLBData> {
   LBDataHolder* getLBData() { return lb_data_.get(); }
 
   /**
-   * \internal \brief Set the minimal amount of historical LB data which should be hold
+   * \internal \brief Set the minimal amount of historical LB data which should be retained
    *
-   * \param[in] hist_len the minimal amount of LB data to hold
+   * \param[in] hist_len the minimal amount of LB data to retain
    */
   void setMinLBDataHistory(uint32_t hist_len) { min_hist_lb_data_ = hist_len; }
 

tests/unit/collection/test_lb_data_retention.cc

@@ -260,7 +260,7 @@ TEST_F(TestLBDataRetention, test_lbdata_config_retention_higher) {
   // Set the new model
   theLBManager()->setLoadModel(persist);
 
-  for (int i=0; i<num_phases; ++i) {
+  for (uint32_t i=0; i<theConfig()->vt_lb_data_retention; ++i) {
     runInEpochCollective([&]{
       // Do some work.
       proxy.broadcastCollective<MyMsg<TestCol>, TestCol::colHandler>();