#1934: Cleanup of NodeLBData interface

Author: thearusable

src/vt/vrt/collection/balance/lb_invoke/lb_manager.cc

@@ -469,7 +469,7 @@ void LBManager::finishedLB(PhaseType phase) {
     "finishedLB\n"
   );
 
-  theNodeLBData()->startIterCleanup(phase, min_hist_lb_data_);
+  theNodeLBData()->startIterCleanup(phase);
   theNodeLBData()->outputLBDataForPhase(phase);
 
   destroyLB();

src/vt/vrt/collection/balance/node_lb_data.cc

@@ -116,11 +116,11 @@ void NodeLBData::clearLBData() {
   next_elm_ = 1;
 }
 
-void NodeLBData::startIterCleanup(PhaseType phase, unsigned int look_back) {
-  if (phase >= look_back) {
-    lb_data_->node_data_.erase(phase - look_back);
-    lb_data_->node_comm_.erase(phase - look_back);
-    lb_data_->node_subphase_comm_.erase(phase - look_back);
+void NodeLBData::startIterCleanup(PhaseType phase) {
+  if (phase >= min_hist_lb_data_) {
+    lb_data_->node_data_.erase(phase - min_hist_lb_data_);
+    lb_data_->node_comm_.erase(phase - min_hist_lb_data_);
+    lb_data_->node_subphase_comm_.erase(phase - min_hist_lb_data_);
   }
 
   // Clear migrate lambdas and proxy lookup since LB is complete

src/vt/vrt/collection/balance/node_lb_data.h

@@ -146,7 +146,7 @@ struct NodeLBData : runtime::component::Component<NodeLBData> {
   /**
    * \internal \brief Cleanup after LB runs
    */
-  void startIterCleanup(PhaseType phase, unsigned int look_back);
+  void startIterCleanup(PhaseType phase);
 
   /**
    * \internal \brief Load and broadcast the LB specification file