From 873f0b7dd5b56ab706a100a1285cbf982ca5afef Mon Sep 17 00:00:00 2001 From: Dennis Felsing Date: Fri, 22 Dec 2023 23:59:14 +0000 Subject: [PATCH] version consistency: ignore min/max errors Seen in https://buildkite.com/materialize/nightlies/builds/5708#018c92cb-89e1-4c7d-8781-275dbad03b2a --- .../version_consistency_ignore_filter.py | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/misc/python/materialize/version_consistency/ignore_filter/version_consistency_ignore_filter.py b/misc/python/materialize/version_consistency/ignore_filter/version_consistency_ignore_filter.py index ea9bd82e08ea..21b4a66ae754 100644 --- a/misc/python/materialize/version_consistency/ignore_filter/version_consistency_ignore_filter.py +++ b/misc/python/materialize/version_consistency/ignore_filter/version_consistency_ignore_filter.py @@ -41,6 +41,7 @@ MZ_VERSION_0_77_0 = MzVersion.parse_mz("v0.77.0") MZ_VERSION_0_78_0 = MzVersion.parse_mz("v0.78.0") +MZ_VERSION_0_81_0 = MzVersion.parse_mz("v0.81.0") class VersionConsistencyIgnoreFilter(GenericInconsistencyIgnoreFilter): @@ -96,6 +97,18 @@ def shall_ignore_expression( ): return YesIgnore("Accepted: no order explicitly specified") + if ( + self.lower_version < MZ_VERSION_0_81_0 <= self.higher_version + and expression.matches( + partial( + matches_fun_by_any_name, + function_names_in_lower_case={"min", "max"}, + ), + True, + ) + ): + return YesIgnore("Implemented min/max for interval and time types in 24007") + return super().shall_ignore_expression(expression, row_selection) def _is_any_date_time_expression(self, expression: Expression) -> bool: