Major frames #177
Merged
Major frames #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check a readme box
…paces need to align in the args...
Including matplotlib show I can visualize shapes. Added a test file for the hyperstruct module, so I can checkout and cover the Stations code.
Added pytest-check as a dependency. Station.show() allows a visual confirmation of the shape being used.
Rounded rectangle still needs work.
Added multiple methods for geometry and internal loads. The Station geometry backend is the primary powerhorse here, and still needs more work.
Added a bit more testing, and tweaked the ellipse object in the show method. Lot's of CI still fails, and test coverage is still poor. Baby steps!
Finishing out the geometry method. This method now calculates all geometry inputs needed for internal loads.
Geometry cuts was previously stuck in a loop. Revised the iteration variables and step routine so it _mostly_ converges now, without being super slow.
Swapped the internal loads method to work for a single cut at a time, just to get the logic correct. To get the redundants, and therefore the loads at each segment centroid, we need to do the whole dange thing. So, this will probably have to swap back, but my brain was hurting.
Still needs some geometry work, and weight values don't seem correct, but she's working!
I need this for development, but I'm adding is as a straight dependency because if I adapt methods for dataframe operations, they will likely be faster than any loop I could write.
Printing some dataframes to identify problem areas.
Added a debug option for geometry_cuts.
Sensitivity study indicates we have convergence issues. A validation case is still needed.
Minor updates as I work through the validation of the method. Going to commit this for a PR and version before overhauling the synthesis routines.
Czarified
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolling in the MajorFrames class! This PR adds the MajorFrames class, and functional synthesis routine.
Defining a MajorFrame with loads, it can be automatically evaluated and even plotted.
There are some issues with the stability and accuracy. I've already started debugging and have some major overhauls planned, but I wanted to merge these changes in so I can start updating dependencies before rolling in the validation work.