Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the trackpad gives a finer magnification compared to keyboard/mousewheel #5

Open
bathienle opened this issue Apr 5, 2022 · 2 comments
Labels
enhancement Improvement of a feature

Comments

@bathienle
Copy link
Member

To fix by having finer magnification with the keyboard/mousewheel as well.

@bathienle bathienle added the bug Something isn't working label Apr 5, 2022
@bathienle bathienle self-assigned this Apr 5, 2022
@urubens
Copy link

urubens commented Apr 22, 2022

To keep consistency with the rest of the implementation, I think it's better to refer here as zoom instead of magnification, even though it describes the same concepts. In Cytomine implementation, we nearly often refer as zoom, an number describing the tier in the image pyramid, 0 being the top of the pyramid. Magnification is more a end-user information: we save the slide magnification at best resolution (pyramid basis) and compute it on the fly using the zoom value.

@bathienle bathienle added enhancement Improvement of a feature and removed bug Something isn't working labels Apr 22, 2022
@bathienle
Copy link
Member Author

Okay, I will refactor the code to refer as zoom from now on.

@bathienle bathienle removed their assignment Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of a feature
Projects
None yet
Development

No branches or pull requests

2 participants