Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factory method allowed argument #538

Merged
merged 5 commits into from
Apr 5, 2024

Conversation

kochounoyume
Copy link
Contributor

I think it would be useful if there were.

As for methods with return values, we did not implement them, judging that they are used infrequently due to the trouble of setting the types of both the argument and the return value.

@neuecc
Copy link
Member

neuecc commented Mar 28, 2024

I think it's okay to include it.
However, it seems better to have T state as the first argument (although the existing one is at the end, I actually want to change that).

@kochounoyume
Copy link
Contributor Author

However, it seems better to have T state as the first argument (although the existing one is at the end, I actually want to change that).

I agree with that.

I am sure that users are used to it, as the arguments are in that order in the recent Cysharp library.

@neuecc
Copy link
Member

neuecc commented Apr 5, 2024

Thank you!

@neuecc neuecc merged commit 0c8057c into Cysharp:master Apr 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants