Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latestRoundData() problem #44

Closed
codehawks-bot opened this issue Aug 5, 2023 · 1 comment
Closed

latestRoundData() problem #44

codehawks-bot opened this issue Aug 5, 2023 · 1 comment
Labels

Comments

@codehawks-bot
Copy link

latestRoundData() problem

Severity

Medium Risk

Relevant GitHub Links

https://github.com/Cyfrin/2023-07-foundry-defi-stablecoin/blob/main/src/libraries/OracleLib.sol#L26

Summary

This is the latestRoundData() problem, the contract call latestRoundData() but does not check the return value

Vulnerability Details

https://github.com/Cyfrin/2023-07-foundry-defi-stablecoin/blob/main/src/libraries/OracleLib.sol#L26

Impact

This could lead to stale prices according to the Chainlink documentation:
https://docs.chain.link/data-feeds/price-feeds/historical-data

Related report:
code-423n4/2021-05-fairside-findings#70

Tools Used

vs code

Recommendations

we can refer to :
sherlock-audit/2023-02-blueberry-judging#94

@PatrickAlphaC
Copy link
Member

We do check. The additional values are outdated and no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants