Skip to content

feat!: drop support for Python <3.9 #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 23, 2025

Conversation

Simoh23999
Copy link
Contributor

trying to fix #805

  • the library no longer supports python versions below 3.10

  • I set 3.10 as the min supported version because 3.9 will no longer be supported in 6 months.

  • I haven’t made any significant changes to the codebase, waiting your point of view
    for example, we could update "Union" and "Optional" types to use the pipe operator | if you like.

Let me know if I should make any additional changes 👍

@Simoh23999 Simoh23999 requested a review from a team as a code owner April 17, 2025 23:42
@jkowalleck
Copy link
Member

I set 3.10 as the min supported version because 3.9 will no longer be supported in 6 months.

we dont plan on dropping py3.9 support right now.

@jkowalleck
Copy link
Member

I haven’t made any significant changes to the codebase, waiting your point of view
for example, we could update "Union" and "Optional" types to use the pipe operator | if you like.

after properly raising the runtime requirement to py3.9, please migrate the code, any dependencies and configs where possible. 👍

@Simoh23999 Simoh23999 marked this pull request as draft April 18, 2025 18:37
@Simoh23999
Copy link
Contributor Author

Ok, thanks for the clarification. I'll try to make those changes

Signed-off-by: Simoh23999 <simocasmina@gmail.com>
Signed-off-by: Simoh23999 <simocasmina@gmail.com>
Signed-off-by: Simoh23999 <simocasmina@gmail.com>
@Simoh23999 Simoh23999 force-pushed the feat/drop-py-3.8-3.9-support branch from 7f15cc2 to d04fc37 Compare April 20, 2025 19:17
@Simoh23999 Simoh23999 marked this pull request as ready for review April 20, 2025 19:35
@Simoh23999 Simoh23999 requested a review from jkowalleck April 20, 2025 19:35
@Simoh23999
Copy link
Contributor Author

Please check these changes.

  • I've updated the code and dependencies
  • As part of the migration to Python 3.9+, I applied changes based on PEP 585, replacing legacy typing generics like Dict and Tuple with built-in generics

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck self-requested a review April 21, 2025 15:16
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
Copy link
Member

thank you for donating this feature, @Simoh23999 .

Please keep your fork of the PR available until it is merged eventually

@jkowalleck jkowalleck added enhancement New feature or request breaking change labels Apr 23, 2025
@jkowalleck jkowalleck changed the title feat!: drop support for end-of-life python versions feat!: drop support for Python <3.9 Apr 23, 2025
@jkowalleck jkowalleck merged commit 8b2a07d into CycloneDX:main Apr 23, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat!: drop support for end-of-life python versions
2 participants