feat: support services data object

[lucamrgs]

• Added (an initial definition of) the "Data" class and other related classes that seemed missing, in the service.py model.
• Substituted use of DataClassification class to Data class in Service
• Modified the tests where previously "DataClassification" was used, to instead use Data.

fixes #672

[lucamrgs]

Still to do:

• Remove dangling uses of DataClassification in serialisation
• Check serialisation decorators and such for the new classes
• Add tests for new properties in Service.Data (especially governance, source, destination)

[lucamrgs]

Still to do:

• Remove dangling uses of DataClassification in serialisation
• Check serialisation decorators and such for the new classes
• Add tests for new properties in Service.Data (especially governance, source, destination)

Hi @jkowalleck, are these todos something that someone could pick up? I'm not very well versed in xml serialisation :')

[jkowalleck]

Still to do:

• Remove dangling uses of DataClassification in serialisation
• Check serialisation decorators and such for the new classes
• Add tests for new properties in Service.Data (especially governance, source, destination)

Hi @jkowalleck, are these todos something that someone could pick up? I'm not very well versed in xml serialisation :')

Serialization is all done by a 3rd party library. It is controlled via function decorators. This concerns XML and JSON serialization.
Just take your time and see existing utilization.

• Check serialisation decorators and such for the new classes

This will be part of a code review.

• Remove dangling uses of DataClassification in serialisation
• [...]
• Add tests for new properties in Service.Data (especially governance, source, destination)

You are the downstream user, so you probably know your scope and cases best.
Just take your time and see existing tests.

No rush; a good feature might take some weeks. :-)

[jkowalleck]

@lucamrgs , I just wanted to know how things are getting along.
DO you need any help with the open discussions/points?

[lucamrgs]

Hi @jkowalleck, thanks for checking in. Unfortunately I have not found time at to address this, and currently using a workaround where I am parsing back and forth a custom service data object into the service properties. Sadly I am not sure of when I can get back to this PR :(