NugetService: Find PackageVulnerabilityInfo from IVulnerabilityInfoResource (Issue 805) #985
+452
−173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 19, 2025 13:18
…ility service mock
LarsPellarin
commented
Nov 20, 2025
|
|
||
| var vulnerabilities = await GetVulnerabilitiesAsync(name, version); | ||
| var vulnerabilityDescriptions = vulnerabilities.OrderBy(v => v.Severity).Select(v => v.ToJson()).ToArray(); | ||
| component.Description = string.Join(',', vulnerabilityDescriptions); |
Author
There was a problem hiding this comment.
No appropriate property found for this, please advice as component is in an external package and cant be modified here
Signed-off-by: MTsfoni <mibau89@gmail.com>
…getServiceDTO - this decouples the library and the nugetService Signed-off-by: MTsfoni <mibau89@gmail.com>
Member
|
@LarsPellarin Cool that you took on that feature! The Class from the CycloneDX-library shouldn't be used in the NugetService imo. I think it still needs to use more fields of the Vulnerability and probably testing (log4net is a classic here, oracle adapter also has vulnerabilities). Let me know if you still want to on, otherwise I will finish it in the coming days. |
Author
|
Thanks for feedback! Agree on the DTO refactor. Feel free to finish this, i will not have time the next couple of days myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NugetService: Add support to find PackageVulnerabilityInfo from IVulnerabilityInfoResource.
Reduce code duplication in test and make it easier to inject vulnerability service mock.
Refactor to inject source repository from factory.