#916 - Allow signing XML BOMs with RSA #976
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leon <leon@1ux.dev>
Signed-off-by: Leon <leon@1ux.dev>
Signed-off-by: Leon <leon@1ux.dev>
Signed-off-by: Leon <leon@1ux.dev>
Signed-off-by: Leon <leon@1ux.dev>
Signed-off-by: Leon <leon@1ux.dev>
Signed-off-by: Leon <leon@1ux.dev>
Signed-off-by: Leon <leon@1ux.dev>
Signed-off-by: Leon <leon@1ux.dev>
Lachstec
force-pushed
the
feature/sign-xml-bom
branch
from
83dc2cb to
ed8253d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #916 by allowing users to directly sign the generated BOM by using the new flag
--signing-key <filepath>and providing an RSA private key. Signature was tested with to verify without errors with the CycloneDX-CLI to ensure compatability.--signing-key(short:-sk) to allow passing a private keyXmlBomSinger.cshandles signing the BOM usingSystem.Security.Cryptography.XmlIt would make sense to also allow signing JSON BOMs and allow the usage of X509 certificates. The CycloneDX-CLI does not seem to support that at this moment, so this PR only implements parity with it. Further work on this could be done in a follow up PR.