Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce "cyclonedx rename-entity" command (bis) #396

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jimklimov
Copy link
Contributor

Re-introduce it in a sense: this was posted earlier as PR #346 and still relies on CycloneDX/cyclonedx-dotnet-library#245 for the bulk of work (BomEntity base-class and interface family, etc.) and CycloneDX/cyclonedx-dotnet-library#256 for metadata update of the output document.

The earlier PR did not fail any formal tests (maybe should have added some, to ensure the contemporary library has the features exposed by it), so was prematurely merged and then reverted back by commit 91cf6c6 before cyclonedx-cli v0.26.0 release.

Primarily as a practical test case for Bom.WalkThis() and
Bom.RenameBomRef() methods introduced in the library, but
may be useful to have exposed for end-users.

Signed-off-by: Jim Klimov <jimklimov@gmail.com>
Signed-off-by: Jim Klimov <jimklimov@gmail.com>
@mtsfoni
Copy link
Contributor

mtsfoni commented Aug 16, 2024

basically this is supposed to change a known bom-ref to another bom-ref?

I wrote this a tool cdx-enrich (will change the name to cdx-edit soon), I don't even use it myself yes, but this could be a good functionality for that tool as well. It can also take a list of operations, so if you plan to overwrite known bom-refs in a pipeline after creating a bom, this could work pretty good.

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants