From fd93d10bcd6c5a7e70c3163910aeb944f92d8ffe Mon Sep 17 00:00:00 2001
From: Reese <10563996+reesercollins@users.noreply.github.com>
Date: Fri, 7 Oct 2022 13:42:38 -0400
Subject: [PATCH] Prevent invalid filter values from being saved (#215)

By assuming that all input is invalid until the api tells us otherwise,
we can prevent the user from clicking the save button in the time between
the value being entered and the api returning.
---
 .../useAdvancedDataTypes.ts                                      | 1 +
 1 file changed, 1 insertion(+)

diff --git a/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/useAdvancedDataTypes.ts b/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/useAdvancedDataTypes.ts
index 206a4e42f047d..31c6af0ba652a 100644
--- a/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/useAdvancedDataTypes.ts
+++ b/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/useAdvancedDataTypes.ts
@@ -47,6 +47,7 @@ const useAdvancedDataTypes = (validHandler: (isValid: boolean) => void) => {
         setAdvancedDataTypesState(INITIAL_ADVANCED_DATA_TYPES_STATE);
         return;
       }
+      validHandler(false);
       debounce(() => {
         const queryParams = rison.encode({
           type: subjectAdvancedDataType,