Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better logging when polling announcements #168

Open
Linus045 opened this issue Feb 8, 2022 · 0 comments
Open

Better logging when polling announcements #168

Linus045 opened this issue Feb 8, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@Linus045
Copy link
Collaborator

Linus045 commented Feb 8, 2022

When using proxies the logging should be improved to see which proxy is used.
See https://github.com/CyberPunkMetalHead/gateio-crypto-trading-bot-binance-announcements-new-coins/pull/139/files#r799502271

It should also be clear when and what source we are polling announcements from as well as any error that might occur.

As mentioned in the linked comment above, my idea for messages are:

when using proxy: "Getting Binance announcements [Using proxy: 127.0.0.1]"
when no valid proxy exists: "Getting Binance announcements [No proxy available]"
when the proxy feature is disabled: "Getting Binance announcements"

The source "Binance" should be replaced which the one we poll from, e.g. Kucoin/other future sources.

@Linus045 Linus045 added the enhancement New feature or request label Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant