merging PR Empact#52

Author: lostapathy

Gemfile

@@ -11,4 +11,5 @@ group :development, :test do
   gem 'sqlite3', '>= 1.2.4'
   gem 'activerecord', '~> 3.1'
   gem 'rack', '< 2.0.0'
+  gem 'equivalent-xml', '>= 0.6.0'
 end

Gemfile.lock

@@ -20,6 +20,8 @@ GEM
     descendants_tracker (0.0.4)
       thread_safe (~> 0.3, >= 0.3.1)
     diff-lcs (1.1.3)
+    equivalent-xml (0.6.0)
+      nokogiri (>= 1.4.3)
     faraday (0.12.2)
       multipart-post (>= 1.2, < 3)
     git (1.3.0)
@@ -82,6 +84,7 @@ PLATFORMS
 DEPENDENCIES
   activerecord (~> 3.1)
   activesupport (~> 3.1)
+  equivalent-xml (>= 0.6.0)
   jeweler (< 2.2.0)
   nokogiri (>= 1.3.3)
   rack (< 2.0.0)

lib/roxml.rb

@@ -42,6 +42,7 @@ def to_xml(params = {})
             ref.update_xml(root, value)
           end
         end
+        params[:namespaces].each { |prefix, url| root.add_namespace_definition(prefix, url) } if params[:namespaces]
       end
     end
   end

roxml.gemspec

@@ -141,9 +141,10 @@ Gem::Specification.new do |s|
       s.add_runtime_dependency(%q<nokogiri>, [">= 1.3.3"])
       s.add_development_dependency(%q<rake>, [">= 0"])
       s.add_development_dependency(%q<jeweler>, [">= 0"])
-      s.add_development_dependency(%q<rspec>, [">= 2.0.0"])
+      s.add_development_dependency(%q<rspec>, ["~> 2.0"])
       s.add_development_dependency(%q<sqlite3-ruby>, [">= 1.2.4"])
       s.add_development_dependency(%q<activerecord>, [">= 2.2.2"])
+      s.add_development_dependency(%q<equivalent-xml>, [">= 0.6.0"])
     else
       s.add_dependency(%q<activesupport>, [">= 2.3.0"])
       s.add_dependency(%q<nokogiri>, [">= 1.3.3"])

spec/spec_helper.rb

@@ -2,6 +2,8 @@
 require 'rubygems'
 require 'pathname'
 require 'ostruct'
+require 'rspec/matchers' # req by equivalent-xml custom matcher `be_equivalent_to`
+require 'equivalent-xml'
 
 require_relative './../test/support/fixtures'
 require_relative './../lib/roxml'

spec/xml/namespace_spec.rb

@@ -28,7 +28,7 @@ class NetworkConfig
 
       xml_name 'NetworkConfig'
       xml_reader    :name, :from => '@name'
-      xml_reader    :errors, :as => []
+      xml_reader    :errors, :as => [], :from => 'gronk:error'
       xml_accessor  :fence_mode, :from => 'vmw:FenceMode'
       xml_accessor  :dhcp?, :from => 'vmw:Dhcp'
     end
@@ -50,9 +50,9 @@ class VApp
     describe "#to_xml" do
       it "should reproduce the input xml" do
         output = ROXML::XML::Document.new
-        output.root = VApp.from_xml(@xml).to_xml
-        pending "Full namespace write support"
-        output.should == ROXML::XML.parse_string(@xml)
+        namespaces = {'vmw' => "http://foo.example.com", 'gronk' => "http://gronk.example.com"}
+        output.root = VApp.from_xml(@xml).to_xml(:namespaces => {'vmw' => "http://foo.example.com", 'gronk' => "http://gronk.example.com"})
+        expect(ROXML::XML.parse_string(output.to_s)).to be_equivalent_to(ROXML::XML.parse_string(@xml))
       end
     end
   end