No need to store fields separately in elasticsearch

That will justlead to fields being stored once - as part of _source as
well as in separate index that would never be used by haystack (would be
used only in special cases when requesting just that field, which can
be, with minimal overhead, still just extracted from the _source as it
is).

Author: CubeXspark

haystack/backends/elasticsearch_backend.py

@@ -624,13 +624,6 @@ def build_schema(self, fields):
             if field_class.document is True:
                 content_field_name = field_class.index_fieldname
 
-            # The docs claim nothing is needed for multivalue...
-            # if field_class.is_multivalued:
-            #     field_data['multi_valued'] = 'true'
-
-            if field_class.stored:
-                field_mapping['store'] = 'yes'
-
             # Do this last to override `text` fields.
             if field_mapping['type'] == 'string':
                 if field_class.indexed is False or hasattr(field_class, 'facet_for'):

tests/elasticsearch_tests/tests/test_elasticsearch_backend.py

@@ -440,10 +440,10 @@ def test_build_schema(self):
         self.assertEqual(content_field_name, 'text')
         self.assertEqual(len(mapping), 4)
         self.assertEqual(mapping, {
-            'text': {'type': 'string', 'analyzer': 'snowball', 'store': 'yes'},
-            'pub_date': {'store': 'yes', 'type': 'date'},
-            'name': {'type': 'string', 'analyzer': 'snowball', 'store': 'yes'},
-            'name_exact': {'index': 'not_analyzed', 'store': 'yes', 'type': 'string'}
+            'text': {'type': 'string', 'analyzer': 'snowball'},
+            'pub_date': {'type': 'date'},
+            'name': {'type': 'string', 'analyzer': 'snowball'},
+            'name_exact': {'index': 'not_analyzed', 'type': 'string'}
         })
 
         ui = UnifiedIndex()
@@ -452,21 +452,21 @@ def test_build_schema(self):
         self.assertEqual(content_field_name, 'text')
         self.assertEqual(len(mapping), 15)
         self.assertEqual(mapping, {
-            'name': {'type': 'string', 'analyzer': 'snowball', 'store': 'yes'},
-            'is_active_exact': {'store': 'yes', 'type': 'boolean'},
-            'created': {'store': 'yes', 'type': 'date'},
-            'post_count': {'store': 'yes', 'type': 'long'},
-            'created_exact': {'store': 'yes', 'type': 'date'},
-            'sites_exact': {'index': 'not_analyzed', 'store': 'yes', 'type': 'string'},
-            'is_active': {'store': 'yes', 'type': 'boolean'},
-            'sites': {'type': 'string', 'analyzer': 'snowball', 'store': 'yes'},
-            'post_count_i': {'store': 'yes', 'type': 'long'},
-            'average_rating': {'store': 'yes', 'type': 'float'},
-            'text': {'type': 'string', 'analyzer': 'snowball', 'store': 'yes'},
-            'pub_date_exact': {'type': 'date', 'store': 'yes'},
-            'name_exact': {'index': 'not_analyzed', 'store': 'yes', 'type': 'string'},
-            'pub_date': {'store': 'yes', 'type': 'date'},
-            'average_rating_exact': {'store': 'yes', 'type': 'float'}
+            'name': {'type': 'string', 'analyzer': 'snowball'},
+            'is_active_exact': {'type': 'boolean'},
+            'created': {'type': 'date'},
+            'post_count': {'type': 'long'},
+            'created_exact': {'type': 'date'},
+            'sites_exact': {'index': 'not_analyzed', 'type': 'string'},
+            'is_active': {'type': 'boolean'},
+            'sites': {'type': 'string', 'analyzer': 'snowball'},
+            'post_count_i': {'type': 'long'},
+            'average_rating': {'type': 'float'},
+            'text': {'type': 'string', 'analyzer': 'snowball'},
+            'pub_date_exact': {'type': 'date'},
+            'name_exact': {'index': 'not_analyzed', 'type': 'string'},
+            'pub_date': {'type': 'date'},
+            'average_rating_exact': {'type': 'float'}
         })
 
     def test_verify_type(self):
@@ -1071,26 +1071,21 @@ def test_build_schema(self):
             'name_auto': {
                 'type': 'string',
                 'analyzer': 'edgengram_analyzer',
-                'store': 'yes'
             },
             'text': {
                 'type': 'string',
                 'analyzer': 'snowball',
-                'store': 'yes'
             },
             'pub_date': {
-                'store': 'yes',
                 'type': 'date'
             },
             'name': {
                 'type': 'string',
                 'analyzer': 'snowball',
-                'store': 'yes'
             },
             'text_auto': {
                 'type': 'string',
                 'analyzer': 'edgengram_analyzer',
-                'store': 'yes'
             }
         })