Skip to content

Commit 0b2c555

Browse files
authored
Merge pull request commercialhaskell#4814 from commercialhaskell/cleanup-pantry-exports
Basic pantry package cleanup
2 parents 8e6d451 + a564ffb commit 0b2c555

26 files changed

Lines changed: 104 additions & 58 deletions

src/Stack/Config.hs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ module Stack.Config
3434

3535
import Control.Monad.Extra (firstJustM)
3636
import Stack.Prelude
37-
import Data.Aeson.Extended
37+
import Pantry.Internal.AesonExtended
3838
import qualified Data.ByteString as S
3939
import Data.ByteString.Builder (byteString)
4040
import Data.Coerce (coerce)
@@ -578,7 +578,7 @@ fillProjectWanted stackYamlFP config project locCache snapCompiler snapPackages
578578
(pl, mCompleted) <- case rpl of
579579
RPLImmutable rpli -> do
580580
compl <- maybe (completePackageLocation rpli) pure (Map.lookup rpli locCache)
581-
pure (PLImmutable compl, Just (rpli, compl))
581+
pure (PLImmutable compl, Just (CompletedPLI rpli compl))
582582
RPLMutable p ->
583583
pure (PLMutable p, Nothing)
584584
dp <- additionalDepPackage (shouldHaddockDeps bopts) pl

src/Stack/Docker.hs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ module Stack.Docker
2626

2727
import Stack.Prelude
2828
import qualified Crypto.Hash as Hash (Digest, MD5, hash)
29-
import Data.Aeson.Extended (FromJSON(..),(.:),(.:?),(.!=),eitherDecode)
29+
import Pantry.Internal.AesonExtended (FromJSON(..),(.:),(.:?),(.!=),eitherDecode)
3030
import qualified Data.ByteString.Char8 as BS
3131
import qualified Data.ByteString.Lazy as BL
3232
import qualified Data.ByteString.Lazy.Char8 as LBS

src/Stack/Lock.hs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ module Stack.Lock
1010
, Locked(..)
1111
) where
1212

13-
import Data.Aeson.Extended
13+
import Pantry.Internal.AesonExtended
1414
import Data.ByteString.Builder (byteString)
1515
import qualified Data.List.NonEmpty as NE
1616
import Data.Map (Map)
@@ -122,9 +122,11 @@ lockCachedWanted stackFile resolver fillWanted = do
122122
let compiler = snapshotCompiler snap
123123
snPkgs = Map.mapWithKey (\n p h -> snapToDepPackage h n p) (snapshotPackages snap)
124124
(wanted, prjCompleted) <- fillWanted Map.empty compiler snPkgs
125-
let lockLocations = map (uncurry LockedLocation)
126-
differentSnapLocs (raw, complete) = raw /= toRawSL complete
127-
newLocked = Locked { lckSnapshotLocations = lockLocations $ filter differentSnapLocs slocCompleted
125+
let lockLocations = map (\(CompletedPLI r c) -> LockedLocation r c)
126+
differentSnapLocs (CompletedSL raw complete)
127+
| raw == toRawSL complete = Nothing
128+
| otherwise = Just $ LockedLocation raw complete
129+
newLocked = Locked { lckSnapshotLocations = mapMaybe differentSnapLocs slocCompleted
128130
, lckPkgImmutableLocations =
129131
lockLocations $ pliCompleted <> prjCompleted
130132
}

src/Stack/Setup.hs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ import Conduit
3333
import Control.Applicative (empty)
3434
import Control.Monad.State (get, put, modify)
3535
import "cryptonite" Crypto.Hash (SHA1(..), SHA256(..))
36-
import Data.Aeson.Extended
36+
import Pantry.Internal.AesonExtended
3737
import qualified Data.ByteString as S
3838
import qualified Data.ByteString.Lazy as LBS
3939
import qualified Data.Conduit.Binary as CB

src/Stack/Storage.hs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ import Database.Persist.Sqlite
4141
import Database.Persist.TH
4242
import Distribution.Text (simpleParse, display)
4343
import Foreign.C.Types (CTime (..))
44-
import qualified Pantry.SQLite as SQLite
44+
import qualified Pantry.Internal as SQLite
4545
import Path
4646
import Path.IO (resolveFile', resolveDir')
4747
import qualified RIO.FilePath as FP

src/Stack/Types/CompilerBuild.hs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ module Stack.Types.CompilerBuild
77
) where
88

99
import Stack.Prelude
10-
import Data.Aeson.Extended (FromJSON, parseJSON, withText)
10+
import Pantry.Internal.AesonExtended (FromJSON, parseJSON, withText)
1111
import Data.Text as T
1212

1313
data CompilerBuild

src/Stack/Types/Config.hs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ module Stack.Types.Config
175175
import Control.Monad.Writer (tell)
176176
import Crypto.Hash (hashWith, SHA1(..))
177177
import Stack.Prelude
178-
import Data.Aeson.Extended
178+
import Pantry.Internal.AesonExtended
179179
(ToJSON, toJSON, FromJSON, FromJSONKey (..), parseJSON, withText, object,
180180
(.=), (..:), (...:), (..:?), (..!=), Value(Bool),
181181
withObjectWarnings, WarningParser, Object, jsonSubWarnings,
@@ -210,7 +210,7 @@ import Lens.Micro (Lens', lens, _1, _2, to)
210210
import Options.Applicative (ReadM)
211211
import qualified Options.Applicative as OA
212212
import qualified Options.Applicative.Types as OA
213-
import Pantry.SQLite (Storage)
213+
import Pantry.Internal (Storage)
214214
import Path
215215
import qualified Paths_stack as Meta
216216
import qualified RIO.List as List

src/Stack/Types/Config/Build.hs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ module Stack.Types.Config.Build
3030
)
3131
where
3232

33-
import Data.Aeson.Extended
33+
import Pantry.Internal.AesonExtended
3434
import qualified Data.Map.Strict as Map
3535
import Generics.Deriving.Monoid (memptydefault, mappenddefault)
3636
import Stack.Prelude

src/Stack/Types/Docker.hs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
module Stack.Types.Docker where
1111

1212
import Stack.Prelude hiding (Display (..))
13-
import Data.Aeson.Extended
13+
import Pantry.Internal.AesonExtended
1414
import Data.List (intercalate)
1515
import qualified Data.Text as T
1616
import Distribution.System (Platform(..), OS(..), Arch(..))

src/Stack/Types/GhcPkgId.hs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ module Stack.Types.GhcPkgId
1414
where
1515

1616
import Stack.Prelude
17-
import Data.Aeson.Extended
17+
import Pantry.Internal.AesonExtended
1818
import Data.Attoparsec.Text
1919
import qualified Data.Text as T
2020
import Database.Persist.Sql (PersistField, PersistFieldSql)

0 commit comments

Comments
 (0)