Merge pull request ironhack-labs#3925 from ironhack-labs/develop

Review changes in iteration 3.2 and update the test assertion

Author: ironhack-edu

README.md

@@ -155,7 +155,7 @@ const numbers = [6, 12, 1, 18, 13, 16, 2, 1, 8, 10];
 
 In iteration 3, you created a function that returns the sum of an array of numbers. But what if we want to calculate the sum of the length of words in an array? What if it also includes _boolean_ values? To achieve this, we must create a function allowing this flexibility.
 
-You should implement the function `sum()` in this iteration. The function should take an array of mixed values - numbers, strings, and booleans. The function should add all the string lengths, numeric values, and numeric values of booleans to the total sum and return the sum. Check the tests for more details.
+You should implement the function `sum()` in this iteration. The function should take an array of mixed values - numbers, strings, and booleans. The function should add all the string lengths, numeric values, and numeric values of booleans to the total sum and return the sum. 
 
 You can use the following array to test your solution:
 
@@ -165,6 +165,14 @@ const mixedArr = [6, 12, 'miami', 1, true, 'barca', '200', 'lisboa', 8, 10];
 // should return: 57
 ```
 
+
+Note: Your function should only accept an array with numbers, strings, or booleans. If the array contains any other data type, such as an object, you should [throw an error](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/throw). In JavaScript, the syntax for throwing an error is as follows:
+```javascript
+throw new Error("Error message goes here");
+```
+
+When specifying the error message, you should be specific and descriptive in explaining the error.
+
 <br>
 
 ### Iteration #4: Calculate the average
@@ -581,4 +589,4 @@ If the link shown is the same as the main Ironhack repository, you will need to
 
   [Back to top](#faqs)
 
-</details>
+</details>

src/functions-and-arrays.js

@@ -1,41 +1,131 @@
 // Iteration #1: Find the maximum
-function maxOfTwoNumbers() {}
+
+function maxOfTwoNumbers(num1, num2) {
+  if (num1 > num2) {
+  return num1;
+  } else if (num2 > num1) {
+    return num2;
+  } else {
+    return num1;
+  }
+}
 
 
 
 // Iteration #2: Find longest word
 const words = ['mystery', 'brother', 'aviator', 'crocodile', 'pearl', 'orchard', 'crackpot'];
 
-function findLongestWord() {}
+function findLongestWord(words) {
+  if (words.length === 0) {
+    return null;
+  }
+  let longestWord = words[0];
+    
+  for (let i = 1; i < words.length; i++) {
+      if (words[i].length > longestWord.length) {
+          longestWord = words[i];
+      }
+  }
+  
+  return longestWord;
+}
 
 
 
 // Iteration #3: Calculate the sum
 const numbers = [6, 12, 1, 18, 13, 16, 2, 1, 8, 10];
 
-function sumNumbers() {}
+function sumNumbers(numbers) {
+  if (numbers.length === 0) {
+    return 0;
+}
+
+let suma = 0;
+
+for (let i = 0; i < numbers.length; i++) {
+    suma += numbers[i];
+}
+
+return suma;
+}
 
 
 
 // Iteration #3.1 Bonus:
-function sum() {}
+function sum(arr) {
+  for (let item of arr) {
+    if (typeof item === 'object' && item !== null) {
+      throw new Error('Unsupported data type');
+    }
+  }
+
+  return arr.reduce((total, item) => {
+    if (typeof item === 'number') {
+      return total + item;
+    } else if (typeof item === 'string') {
+      return total + item.length;
+    } else if (typeof item === 'boolean') {
+      return total + (item ? 1 : 0);
+    } else {
+      return total;
+    }
+  }, 0);
+}
 
 
 
 // Iteration #4: Calculate the average
 // Level 1: Array of numbers
-const numbersAvg = [2, 6, 9, 10, 7, 4, 1, 9];
+function averageNumbers(arr) {
+  if (arr.length === 0) {
+    return null;
+  }
 
-function averageNumbers() {}
+  const sum = arr.reduce((total, num) => total + num, 0);
 
+  const average = sum / arr.length;
+
+  return average;
+}
 
 // Level 2: Array of strings
 const wordsArr = ['seat', 'correspond', 'linen', 'motif', 'hole', 'smell', 'smart', 'chaos', 'fuel', 'palace'];
 
-function averageWordLength() { }
+function averageWordLength(arr) {
+  
+  if (arr.length === 0) {
+    return null;
+  }
+
+  const sumOfLengths = arr.reduce((total, word) => total + word.length, 0);
+
+  const averageLength = sumOfLengths / arr.length;
+
+  return averageLength;
+}
 
 // Bonus - Iteration #4.1
-function avg() {}
+function avg(arr) {
+  if (arr.length === 0) {
+    return null;
+  }
+
+  const sum = arr.reduce((total, item) => {
+    if (typeof item === 'number') {
+      return total + item;
+    } else if (typeof item === 'string') {
+      return total + item.length;
+    } else if (typeof item === 'boolean') {
+      return total + (item ? 1 : 0);
+    } else {
+      throw new Error('Unsupported data type');
+    }
+  }, 0);
+
+  const average = sum / arr.length;
+
+  return average;
+}
 
 // Iteration #5: Unique arrays
 const wordsUnique = [
@@ -52,14 +142,28 @@ const wordsUnique = [
   'bring'
 ];
 
-function uniquifyArray() {}
+function uniquifyArray(arr) {
+  if (arr.length === 0) {
+    return null;
+  }
+
+  const uniqueSet = new Set(arr);
+
+  return Array.from(uniqueSet);
+}
 
 
 
 // Iteration #6: Find elements
 const wordsFind = ['machine', 'subset', 'trouble', 'starting', 'matter', 'eating', 'truth', 'disobedience'];
 
-function doesWordExist() {}
+function doesWordExist(arr, word) {
+  if (arr.length === 0) {
+    return null;
+  }
+
+  return arr.includes(word);
+}
 
 
 
@@ -78,7 +182,21 @@ const wordsCount = [
   'matter'
 ];
 
-function howManyTimes() {}
+function howManyTimes(arr, word) {
+  if (arr.length === 0) {
+    return 0;
+  }
+
+  let count = 0;
+
+  for (let i = 0; i < arr.length; i++) {
+    if (arr[i] === word) {
+      count++;
+    }
+  }
+
+  return count;
+}
 
 
 
@@ -106,7 +224,35 @@ const matrix = [
   [1, 70, 54, 71, 83, 51, 54, 69, 16, 92, 33, 48, 61, 43, 52, 1, 89, 19, 67, 48]
 ];
 
-function greatestProduct() {}
+function greatestProduct(matrix) {
+  if (!matrix || matrix.length === 0) {
+    return null;
+  }
+
+  const rows = matrix.length;
+  const cols = matrix[0].length;
+  let maxProduct = 0;
+
+  for (let i = 0; i < rows; i++) {
+    for (let j = 0; j <= cols - 4; j++) {
+      let product = matrix[i][j] * matrix[i][j+1] * matrix[i][j+2] * matrix[i][j+3];
+      if (product > maxProduct) {
+        maxProduct = product;
+      }
+    }
+  }
+
+  for (let i = 0; i <= rows - 4; i++) {
+    for (let j = 0; j < cols; j++) {
+      let product = matrix[i][j] * matrix[i+1][j] * matrix[i+2][j] * matrix[i+3][j];
+      if (product > maxProduct) {
+        maxProduct = product;
+      }
+    }
+  }
+
+  return maxProduct;
+}
 
 
 
@@ -127,4 +273,4 @@ if (typeof module !== 'undefined') {
     howManyTimes,
     greatestProduct
   };
-}
+}

tests/functions-and-arrays.spec.js

@@ -120,9 +120,7 @@ describe('Bonus: Calculate the sum', () => {
   });
 
   it('should throw an error when unsupported data type (object or array) present in the array', () => {
-    expect(() => sum([6, 12, 'miami', 1, 'barca', '200', 'lisboa', 8, [], {}])).toThrow(
-      new Error("Unsupported data type sir or ma'am")
-    );
+    expect(() => sum([6, 12, 'miami', 1, 'barca', '200', 'lisboa', 8, [], {}])).toThrow();
   });
 
 });